Bug 260873 - print/libotf: add X11 option and fix otfview build
Summary: print/libotf: add X11 option and fix otfview build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-01-02 09:57 UTC by Jan Beich
Modified: 2022-01-15 02:17 UTC (History)
2 users (show)

See Also:
nikola.lecic: maintainer-feedback+
jbeich: merge-quarterly+

Attachments
v1 (apply via "git am") (1.53 KB, patch)
2022-01-02 09:57 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2022-01-02 09:57:54 UTC 
Created attachment 230620 [details]
v1 (apply via "git am")

I'd like to build editors/emacs-devel with PGTK option for Wayland-only environment without disabling OTF option. Currently, print/libotf checks for X11 dependencies but doesn't use.

$ poudriere testport -j 122amd64 print/libotf
[...]
checking X11/Xaw/Command.h usability... no
checking X11/Xaw/Command.h presence... no
checking for X11/Xaw/Command.h... no
[...]
configure:12848: checking X11/Xaw/Command.h usability
configure:12848: cc -c -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing   conftest.c >&5
conftest.c:61:10: fatal error: 'X11/Xaw/Command.h' file not found
#include <X11/Xaw/Command.h>
         ^~~~~~~~~~~~~~~~~~~
[...]
=>> Checking shared library dependencies
 0x0000000000000001 NEEDED               Shared library: [libc.so.7]
 0x0000000000000001 NEEDED               Shared library: [libfreetype.so.6]
 0x0000000000000001 NEEDED               Shared library: [libotf.so.1]
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-12 07:55:49 UTC 
^Triage: Reporter is committer, assign accordingly.
Comment 2 Nikola Lečić 2022-01-15 01:22:47 UTC 
I approve, thank you very much for your time.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-01-15 02:16:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=360ad16edd05b0c135063dd40e9f6ae292120d56

commit 360ad16edd05b0c135063dd40e9f6ae292120d56
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-01-02 09:02:12 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-01-15 02:03:54 +0000

    print/libotf: add X11 option and fix otfview build

    PR:             260873
    Approved by:    Nikola Lečić (maintainer)

 print/libotf/Makefile  | 12 ++++++++++--
 print/libotf/pkg-plist |  1 +
 2 files changed, 11 insertions(+), 2 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-01-15 02:16:32 UTC 
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5515fdf0500f7176f509b825f41fa0caed7c2020

commit 5515fdf0500f7176f509b825f41fa0caed7c2020
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-01-02 09:02:12 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-01-15 02:16:13 +0000

    print/libotf: add X11 option and fix otfview build

    PR:             260873
    Approved by:    Nikola Lečić (maintainer)

    (cherry picked from commit 360ad16edd05b0c135063dd40e9f6ae292120d56)

 print/libotf/Makefile  | 12 ++++++++++--
 print/libotf/pkg-plist |  1 +
 2 files changed, 11 insertions(+), 2 deletions(-)