Bug 260916 - x11-toolkits/pango: update to 1.50.3
Summary: x11-toolkits/pango: update to 1.50.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL: https://gitlab.gnome.org/GNOME/pango/...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-01-04 00:52 UTC by Jan Beich
Modified: 2022-01-08 08:56 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (desktop)
antoine: exp-run+


Attachments
v1 (apply via "git am") (1.59 KB, patch)
2022-01-04 00:52 UTC, Jan Beich
no flags Details | Diff
v1 (apply via "git am") (24.60 KB, patch)
2022-01-04 01:01 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2022-01-04 00:52:25 UTC
Created attachment 230675 [details]
v1 (apply via "git am")
Comment 1 Jan Beich freebsd_committer freebsd_triage 2022-01-04 01:01:37 UTC
Created attachment 230676 [details]
v1 (apply via "git am")

Oops, fix pkg-plist.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-01-04 01:30:18 UTC
More tests fails on 13-STABLE (amd64)

15/26 test-font (also fails using 1.48.10)
23/26 test-layout (new failure)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-01-04 03:00:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=901d4d41f866b1cf8a7f61ea9494aab8193b6d80

commit 901d4d41f866b1cf8a7f61ea9494aab8193b6d80
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-01-04 02:51:24 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-01-04 02:57:20 +0000

    x11-toolkits/pangomm: unbreak build with pango >= 1.50

    attrlist.cc:38:20: error: use of undeclared identifier 'pango_parse_markup'
      gboolean bTest = pango_parse_markup(markup_text.c_str(), -1 /* means null-terminated */, accel_marker,
                       ^
    attrlist.cc:65:20: error: use of undeclared identifier 'pango_parse_markup'
      gboolean bTest = pango_parse_markup(markup_text.c_str(), -1 /* means null-terminated */, accel_marker,
                       ^

    PR:             260916
    Regressed by:   https://gitlab.gnome.org/GNOME/pango/-/commit/d8df0da73752

 .../files/patch-pango_pangomm_attributes.h (new)   | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-01-06 18:31:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=20c0152349bce047bb3198451234946f849f3d6b

commit 20c0152349bce047bb3198451234946f849f3d6b
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-01-06 18:27:16 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-01-06 18:29:37 +0000

    x11-toolkits/pangoxsl: unbreak build with pango >= 1.50

    In file included from pango-xsl-attributes.c:25:
    ./pango-xsl-attributes.h:116:18: error: conflicting types for 'pango_attr_line_height_new'
    PangoAttribute * pango_attr_line_height_new (gint line_height);
                     ^
    /usr/local/include/pango-1.0/pango/pango-attributes.h:607:25: note: previous declaration is here
    PangoAttribute *        pango_attr_line_height_new              (double                       factor);
                            ^
    pango-xsl-attributes.c:620:1: error: conflicting types for 'pango_attr_line_height_new'
    pango_attr_line_height_new (gint line_height)
    ^
    /usr/local/include/pango-1.0/pango/pango-attributes.h:607:25: note: previous declaration is here
    PangoAttribute *        pango_attr_line_height_new              (double                       factor);
                            ^

    PR:             260916
    Reported by:    antoine (via exp-run)
    Regressed by:   https://gitlab.gnome.org/GNOME/pango/-/commit/623134f48ad9

 x11-toolkits/pangoxsl/files/patch-pango-1.50 (new) | 53 ++++++++++++++++++++++
 1 file changed, 53 insertions(+)
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2022-01-08 08:15:33 UTC
This should be fine
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-01-08 08:48:40 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=47d5c85115d8aadf3ccc9170969673b85a2228c0

commit 47d5c85115d8aadf3ccc9170969673b85a2228c0
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-12-22 02:49:46 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-01-08 08:35:23 +0000

    x11-toolkits/pango: update to 1.50.3

    Changes:        https://gitlab.gnome.org/GNOME/pango/-/blob/1.50.3/NEWS
    PR:             260916
    Exp-run by:     antoine
    Approved by:    tcberner

 x11-toolkits/pango/Makefile  |  4 +-
 x11-toolkits/pango/distinfo  |  6 +--
 x11-toolkits/pango/pkg-plist | 93 +++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 96 insertions(+), 7 deletions(-)
Comment 8 Jan Beich freebsd_committer freebsd_triage 2022-01-08 08:56:51 UTC
(In reply to Daniel Engberg from comment #2)
> 23/26 test-layout (new failure)

Was it marked SKIP in 1.48.10? Better file a bug upstream. Debugging tests is time-consuming and not very useful without FreeBSD CI upstream or an actual application affected.