Bug 260976 - devel/ispc: added support for LLVM 13
Summary: devel/ispc: added support for LLVM 13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-06 13:53 UTC by Vladimir Druzenko
Modified: 2022-01-13 22:27 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)
vvd: maintainer-feedback?

Attachments
added support for LLVM 13 (2.99 KB, patch)
2022-01-06 13:53 UTC, Vladimir Druzenko 		vvd: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2022-01-06 13:53:45 UTC 
Created attachment 230756 [details]
added support for LLVM 13

Tested on 12.2 amd64.
Build fine with LLVM 11, 12 and 13.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2022-01-08 18:45:35 UTC 
Hi VVD,

Thanks for the patch.

With this patch build fails with llvm-13: https://people.freebsd.org/~yuri/ispc-1.16.1_1.log


Yuri
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2022-01-08 20:39:20 UTC 
(In reply to Yuri Victorovich from comment #1)
File /usr/local/llvm13/include/llvm/GenXIntrinsics/GenXMetadata.h is from devel/vc-intrinsics:
enum KernelMDOp {
  FunctionRef,  // Reference to Function
  Name,         // Kernel name
  ArgKinds,     // Reference to metadata node containing kernel arg kinds
  SLMSize,      // SLM-size in bytes
  ArgOffsets,   // Kernel argument offsets
  ArgIOKinds,   // Reference to metadata node containing kernel argument
                // input/output kinds
  ArgTypeDescs, // Kernel argument type descriptors
  NBarrierCnt,  // Named barrier count
  BarrierCnt    // Barrier count
}

You have too old devel/vc-intrinsics:
> ===>   Installing existing package /packages/All/vc-intrinsics-llvm13-s20211011.pkg
> [13amd64-local-workstation-job-01] Installing vc-intrinsics-llvm13-s20211011...
> [13amd64-local-workstation-job-01] Extracting vc-intrinsics-llvm13-s20211011: .......... done

# pkg which /usr/local/llvm13/include/llvm/GenXIntrinsics/GenXMetadata.h
/usr/local/llvm13/include/llvm/GenXIntrinsics/GenXMetadata.h was installed by package vc-intrinsics-llvm13-s20211222
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2022-01-08 21:23:52 UTC 
Committed with the correction of the #if line in the Makefile.

Thanks for the patch!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-01-08 21:24:57 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e083afb30dbfe0b9c2be4ff751d0f775e40b4638

commit e083afb30dbfe0b9c2be4ff751d0f775e40b4638
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-01-08 21:20:49 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-01-08 21:23:52 +0000

    devel/ispc: Add support for LLVM 13

    PR:             260976
    Submitted by:   VVD <vvd@unislabs.com> (original version)

 devel/ispc/Makefile                   | 14 ++++++++------
 devel/ispc/files/patch-src_module.cpp | 14 ++++++++++++++
 devel/ispc/files/patch-src_opt.cpp    | 15 +++++++++++++++
 3 files changed, 37 insertions(+), 6 deletions(-)
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2022-01-08 22:48:19 UTC 
(In reply to Yuri Victorovich from comment #3)
Why min version is 13?
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2022-01-08 23:25:46 UTC 
(In reply to VVD from comment #5)


Because ISPC always said that they require the bleeding edge LLVM, and don't guarantee stable work on older LLVM. Before I was thinking to keep it at -devel even.


Yuri
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2022-01-13 22:27:54 UTC 
I reverted the LLVM version to 11 due to assertions.
See bug#261185.

Let's just leave it at 11 for the time being.


Yuri