Bug 260992 - devel/fstrm: Use upstream release archive
Summary: devel/fstrm: Use upstream release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-06 23:42 UTC by Daniel Engberg
Modified: 2022-01-16 13:56 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (freebsd)

Attachments
Patch for fstrm (1.28 KB, patch)
2022-01-06 23:42 UTC, Daniel Engberg 		no flags Details | Diff
fstrm - additional mastersite (1.33 KB, patch)
2022-01-10 13:47 UTC, Leo Vandewoestijne 		freebsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-01-06 23:42:38 UTC 
Created attachment 230771 [details]
Patch for fstrm

Use upstream release archive as recommended in Porters Handbook
This also removes the need to run USES= autoreconf

Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 13.0-RELEASE (i386)
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-07 07:11:43 UTC 
^Triage: Reporter is committer, assign accordingly.
Comment 2 Leo Vandewoestijne 2022-01-10 13:47:00 UTC 
Created attachment 230877 [details]
fstrm - additional mastersite

While at it; same patch with additional mastersite.
Looks all fine / tested all fine.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-01-16 13:55:46 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=110c4877c8c6ce300ff24be1e2bb33f1b98a3d17

commit 110c4877c8c6ce300ff24be1e2bb33f1b98a3d17
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-01-16 13:44:08 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-01-16 13:44:16 +0000

    devel/fstrm: Use upstream release archive

    Use upstream release archive instead of USE_GITHUB as recommended in
    Porters Handbook

    PR:             260992
    Reviewed by:    Leo Vandewoestijne <freebsd@dns.company> (maintainer)

 devel/fstrm/Makefile | 10 ++++------
 devel/fstrm/distinfo |  6 +++---
 2 files changed, 7 insertions(+), 9 deletions(-)