Bug 261096 - lang/sbcl: should also be enabled for arm64
Summary: lang/sbcl: should also be enabled for arm64
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://sbcl.sourceforge.io/news.html...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-11 00:50 UTC by Robert Clausecker
Modified: 2023-05-25 11:29 UTC (History)
3 users (show)

See Also:
fuz: maintainer-feedback-


Attachments
v0 (3.19 KB, patch)
2022-04-04 11:12 UTC, Mikael Urankar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-01-11 00:50:09 UTC
With sbcl version 2.2.0, support for aarch64 FreeBSD has been added to upstream.  Could you look into amending the port so it supports this architecture?
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2022-04-04 11:12:46 UTC
Created attachment 232926 [details]
v0

Try this patch (it works here)
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-04-04 11:20:55 UTC
Maintainer timeout.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-04-04 12:13:12 UTC
(In reply to Mikael Urankar from comment #1)

LGTM.

Tested with Poudriere on arm64 FreeBSD 13.  The test suite passes.  Check perhaps if BOOTVERSION can be raised to 2.2.0 for all architectures.
Comment 4 Kirill Ponomarev freebsd_committer freebsd_triage 2022-04-04 13:05:27 UTC
yes, we have to update bootstrap for all archs, the new version fails because of that
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-05-03 05:32:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=15b1da831b7cbebe2762fccebcfb3b0d50b27fc9

commit 15b1da831b7cbebe2762fccebcfb3b0d50b27fc9
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2022-04-04 11:00:54 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2022-05-03 05:22:17 +0000

    lang/sbcl: Add aarch64 support

    PR:             261096
    Reported by:    Robert Clausecker
    Approved by:    krion (maintainer timeout)

 lang/sbcl/Makefile | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)
Comment 6 Mikael Urankar freebsd_committer freebsd_triage 2022-05-03 12:39:02 UTC
still an issue
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2022-05-03 12:51:08 UTC
Looks like the patch was reverted.  What happened?
Comment 8 Mikael Urankar freebsd_committer freebsd_triage 2022-05-03 12:54:25 UTC
Ask krion, I'm not involved with this issue anymore.
Comment 9 Ed Maste freebsd_committer freebsd_triage 2022-05-03 13:14:07 UTC
Was reverted in the following commit, but it does not say why:

commit 322efcae932a4ac7090f990ba07a23b85d40bc92
Author: Kirill Ponomarev <krion@FreeBSD.org>
Date:   Tue May 3 09:17:04 2022 +0200

    lang/sbcl: Revert "lang/sbcl: Add aarch64 support"
    
    This reverts commit 15b1da831b7cbebe2762fccebcfb3b0d50b27fc9.
Comment 10 Dmitri Goutnik freebsd_committer freebsd_triage 2022-05-03 14:17:55 UTC
`make test` results on aarch64 12.1-STABLE (AWS Graviton a1.large):

Finished running tests.
Status:
 Expected failure:   dynamic-extent.pure.lisp / DX-COMPILER-NOTES
 Expected failure:   float.pure.lisp / (SCALE-FLOAT-OVERFLOW BUG-372)
 Expected failure:   float.pure.lisp / (ADDITION-OVERFLOW BUG-372)
 Expected failure:   float.pure.lisp / (ADDITION-OVERFLOW BUG-372 TAKE-2)
 Expected failure:   hash.pure.lisp / SXHASH-ON-DISPLACED-STRING
 Expected failure:   selfbuild-output.pure.lisp / MAKE-LIST-%MAKE-LIST-NOT-CALLED
 Skipped (broken):   debug.impure.lisp / (TRACE ENCAPSULATE NIL)
 Skipped (broken):   debug.impure.lisp / (TRACE ENCAPSULATE NIL RECURSIVE)
 Expected failure:   fopcompiler.impure.lisp / FOPCOMPILER-DEPRECATED-VAR-WARNING
 Expected failure:   full-eval.impure.lisp / INLINE-FUN-CAPTURES-DECL
 Skipped (broken):   gethash-concurrency.impure.lisp / (HASH-TABLE UNSYNCHRONIZED)
 Expected failure:   packages.impure.lisp / USE-PACKAGE-CONFLICT-SET
 Expected failure:   packages.impure.lisp / IMPORT-SINGLE-CONFLICT
 Expected failure:   walk.impure.lisp / (WALK MULTIPLE-VALUE-BIND)
 Expected failure:   walk.impure.lisp / (WALK MULTIPLE-VALUE-BIND SPECIAL)
 (58 tests skipped for this combination of platform and features)
ok
//apparent success (reached end of run-tests.sh normally)
Comment 11 Kirill Ponomarev freebsd_committer freebsd_triage 2022-05-03 20:47:08 UTC
(In reply to Ed Maste from comment #9)
The reason is the merge was done with some errors which I outlined in mailing list, after that mikael@ removed those parts but apparently no one tested sbcl functionality on arm64 except of poudriere build.
See my comments on 2022.4.4, bootstrap for arm64 as well as for amd64 contains some issues which are still under review at upstream.
I don't know why the committer put "maintainer timeout" into original commit.
Comment 12 Robert Clausecker freebsd_committer freebsd_triage 2022-05-03 23:01:06 UTC
(In reply to Kirill Ponomarev from comment #11)

> I don't know why the committer put "maintainer timeout" into original commit.

You have not accepted or declined the patch in multiple months.  Your only response to this PR was comment #4 after which another month passed without any further response.  Maintainer timeout is after two weeks, so this is appropriate.
Comment 13 Robert Clausecker freebsd_committer freebsd_triage 2022-10-30 11:53:33 UTC
Any progress on this one?
Comment 14 Robert Clausecker freebsd_committer freebsd_triage 2023-05-25 11:29:16 UTC
Giving up on this one due to lack of maintainer interest.