Bug 261263 - devel/git-lfs: Use upstream release archive
Summary: devel/git-lfs: Use upstream release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vinícius Zavam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-17 08:13 UTC by Daniel Engberg
Modified: 2022-02-13 19:45 UTC (History)
0 users

See Also:
egypcio: maintainer-feedback+


Attachments
Patch for git-lfs (1.21 KB, patch)
2022-01-17 08:13 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-01-17 08:13:43 UTC
Created attachment 231065 [details]
Patch for git-lfs

Use upstream release archive as recommended by Porters Handbook (USE_GITHUB section)

Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist)
Comment 1 Vinícius Zavam freebsd_committer freebsd_triage 2022-02-05 12:27:34 UTC
ACK
Comment 2 Vinícius Zavam freebsd_committer freebsd_triage 2022-02-05 12:36:42 UTC
well, after reading this section (again, to be clear): it does look like you patches it against the recommendations.

USE_GITHUB=yes is the way to go.

https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-distfiles

I'll close this one, as no relevant changes to the port itself are applied. but thanks anyway
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-02-05 17:04:47 UTC
You're not reading the relevant section.

- 5.4.3. USE_GITHUB

If the distribution file comes from a specific commit or tag on GitHub ***for which there is no officially released file***, there is an easy way to set the right DISTNAME and MASTER_SITES automatically.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-02-10 23:40:02 UTC
Friendly ping
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-02-13 19:44:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1c8540de08e23eb25446a8ac22e45660632bbb71

commit 1c8540de08e23eb25446a8ac22e45660632bbb71
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-02-13 19:01:30 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-02-13 19:43:32 +0000

    devel/git-lfs: Use upstream release archive

    Use upstream release archive as recommended by Porters Handbook
    (USE_GITHUB section)

    PR:             261263
    Reviewed by:    egypcio (maintainer)

 devel/git-lfs/Makefile | 10 ++++++----
 devel/git-lfs/distinfo |  6 +++---
 2 files changed, 9 insertions(+), 7 deletions(-)