Created attachment 231143 [details] patch (made with git format-patch) mkdocs-redirect is an MkDocs plugin to create page redirects in MkDocs generated websites. poudriere testport: OK portlint: OK (just a warning about directory for dependency mkdocs, but it seems the case for other Python ports).
Review items: - Match COMMENT to upstream setup.py:Description modulo portlint requirements: 'MkDocs plugin for dynamic page redirects to prevent broken links' - Consider using github sources to include test suite (ask upstream to include these in the distributed PyPI sdist), and adding TEST_DEPENDS and a (do-)test target. Github sources also include LICENSE_FILE (add to Makefile) and ask upstream to include it in the sdist too. - Make port USE_PYTHON=concurrent safe, as package provides files in non-Python version specific locations (console scripts / entry points). What is the warning for the dependency directory?
(In reply to Kubilay Kocak from comment #1) I'm waiting a response from upstream (https://github.com/datarobot/mkdocs-redirects/issues/30). Actions are needed by upstream, for CHEESHOP and for Github in order to use one of them to make the port complete. I will then make a new patch. About portlint, the warning is: WARN: Makefile: you may want directory for dependency mkdocs>=1.0.4 to be textproc/py-mkdocs@${PY_FLAVOR}
Created attachment 231531 [details] updated patch (made with git format-patch) Here is a new patch to have a correct port for mkdocs-redirects. Items from review were corrected (usage of concurrent in USE_PYTHON, Github as the dist source, fix of COMMENT, test target addition). However, I did not have a response from upstream about the missing tags in the git repository (and the missing stuff in sdist but this is not a problem when using Github), so the commit SHA is used to point to version 1.0.3, I hope this is ok (at least for now). Indeed, I need both py-mkdocs-redirects and py-mkdocs-simple-hooks (bug 261322) to update the port sysutils/chezmoi to a newer version (those two MkDocs plugins are required to build the documentation). Thanks
Created attachment 231532 [details] correct updated patch for textproc/py-mkdocs-redirects
Created attachment 231533 [details] patch (made with git format-patch) This is an updated patch with a fixed test target.
Committed!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e619c0be64df05373d75b857b95d0f0c03ebe85b commit e619c0be64df05373d75b857b95d0f0c03ebe85b Author: Samir Noir <samir@noir.im> AuthorDate: 2022-02-03 11:37:14 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2022-03-12 05:43:39 +0000 textproc/py-mkdocs-redirects: New port PR: 261321 textproc/Makefile | 1 + textproc/py-mkdocs-redirects/Makefile (new) | 28 ++++++++++++++++++++++++++++ textproc/py-mkdocs-redirects/distinfo (new) | 3 +++ textproc/py-mkdocs-redirects/pkg-descr (new) | 3 +++ 4 files changed, 35 insertions(+)