Bug 261835 - math/R: Add cmake dependency
Summary: math/R: Add cmake dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-09 18:11 UTC by Yuri Victorovich
Modified: 2022-02-19 23:10 UTC (History)
0 users

See Also:
jrm: maintainer-feedback+


Attachments
patch (723 bytes, patch)
2022-02-09 18:11 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2022-02-09 18:11:13 UTC
Created attachment 231686 [details]
patch

Some R packages can now be built with cmake.
Comment 1 Joseph Mingrone freebsd_committer freebsd_triage 2022-02-19 15:54:47 UTC
Is this still a small proportion of packages?  I haven't encountered any that require cmake, but I only install a small number of R packages.  cmake is a fairly heavy dependency, so I think it's best to avoid it unless it's clearly ncessary.

Part of the reason for putting a dependency on gmake, was that it was often unclear for users that problems encountered when building R packages were because our bmake was being used when gmake was required.  For packages that require cmake, I assume the solution would be obvious, `pkg install cmake
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2022-02-19 16:57:35 UTC
(In reply to Joseph Mingrone from comment #1)

I encountered one such package, but this might be a growing trend.


Yuri
Comment 3 Joseph Mingrone freebsd_committer freebsd_triage 2022-02-19 17:01:44 UTC
What packages was it?  I'll check whether the error message(s) are clear enough for users to be aware that a solution is `pkg install cmake`.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2022-02-19 21:52:24 UTC
(In reply to Joseph Mingrone from comment #3)

The package is 'nloptr'.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-02-19 23:10:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=726cccf6204a22ff5ddec83da25e681f65541baa

commit 726cccf6204a22ff5ddec83da25e681f65541baa
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-02-19 23:07:08 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2022-02-19 23:09:40 +0000

    math/R: Add cmake dependency

    Some R packages such as nloptr require CMake to build.

    PR:             261835

    Approved by:    jrm (maintainer)

 math/R/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 6 Joseph Mingrone freebsd_committer freebsd_triage 2022-02-19 23:10:58 UTC
Seems reasonable.  Thanks.