Bug 261922 - irc/hexchat: Some fixes to port
Summary: irc/hexchat: Some fixes to port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-13 09:14 UTC by Daniel Engberg
Modified: 2022-02-13 21:39 UTC (History)
0 users

See Also:
pkubaj: maintainer-feedback+
koobs: merge-quarterly?

Attachments
Patch for hexchat (2.11 KB, patch)
2022-02-13 09:14 UTC, Daniel Engberg 		pkubaj: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-02-13 09:14:20 UTC 
Created attachment 231785 [details]
Patch for hexchat

- Use upstream release archive as recommended by Porters HandBook (USE_GITHUB section)
- Define gdkpixbuf2 dependency (reported by Poudriere)
- Adjust SHEBANG_FILES to remove the need to define BINARY_ALIAS
- Remove INSTALL_TARGET
- Define INSTALLS_ICONS (ported by Portlint)

Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2022-02-13 11:28:59 UTC 
Looks good, please commit!
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-02-13 19:44:42 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6a7cf963707c250eaeece3041dd65991cdfe566d

commit 6a7cf963707c250eaeece3041dd65991cdfe566d
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-02-13 18:48:12 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-02-13 19:43:32 +0000

    irc/hexchat: Some fixes to port

    - Use upstream release archive as recommended by Porters Handbook
      (USE_GITHUB section)
    - Define gdkpixbuf2 dependency (reported by Poudriere)
    - Adjust SHEBANG_FILES to remove the need to define BINARY_ALIAS
    - Remove INSTALL_TARGET
    - Define INSTALLS_ICONS (reported by Portlint)
    - Remove unnecessary LIBS variable

    PR:             261922
    Reviewed by:    pkubaj (maintainer)

 irc/hexchat/Makefile | 24 ++++++++++--------------
 irc/hexchat/distinfo |  6 +++---
 2 files changed, 13 insertions(+), 17 deletions(-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-02-13 19:45:08 UTC 
Thanks for prompt review
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-13 21:39:16 UTC 
(In reply to commit-hook from comment #2)

Is quarterly affected by these issues/fixes? If so, please MFH