Created attachment 231932 [details] multimedia/mkclean patch This port was pretty out of date and got converted to cmake. I'm not sure if the changes I made are ideal, but the port seems to build and work for me. Thank you!
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. Q/A: PORTREVISION should be removed since this is a version bump. Thanks!
Created attachment 232045 [details] multimedia/mkclean patch Without PORTREVISION.
The port misses a pkg-plist file. Try to run make check-plist and create a suitable pkg-plist file.
(In reply to Kurt Jaeger from comment #3) Does PLIST_FILES in Makefile count? This port only needs those two files. Extra files are added to the staging directory that don't need to be there and might conflict with other ports. Not sure how to stop the install step with cmake.
(In reply to sega01 from comment #4) Handbook here says that PLIST_FILES is okay for just a few, and this is only two files. https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-desc I can still do a pkg-plist file if it's needed.
(In reply to sega01 from comment #5) Yes, PLIST_FILES is perfectly fine in this case.
(In reply to sega01 from comment #4) In theory, yes. The poudriere testbuild listed approx. 20 files. https://people.freebsd.org/~pi/logs/mkclean.txt for the log
(In reply to Kurt Jaeger from comment #7) I'm not sure how to prevent those files from making it to the staging directory. Would it be acceptable to delete them in post-stage, and only copy the two that are needed?
(In reply to sega01 from comment #8) That would be a solution. Alternatively, ship a pkg-plist to install these files, too.
Created attachment 232049 [details] multimedia/mkclean patch This should fix the make check-plist issues.
Created attachment 232050 [details] multimedia/mkclean patch Replaces rm with ${RM}.
Does anyone have any suggestions for how I can make the package build reproducible? The produced binaries have the same checksum, but the staging directory has different timestamps, I think because of the ${CP} and ${MKDIR} commands. Is there some kind of a SOURCE_DATE_EPOCH way to preserve this?
(In reply to sega01 from comment #11) testbuilds are fine.
Comment on attachment 232050 [details] multimedia/mkclean patch First, thanks for working on this. I have started using Matroska muxing over the past year and this tool looks like one I might find useful. I am not competent to comment on most aspects of your update, though those I am look good. One suggestion is that you might request for testers of the updated version on the platforms that are currently marked as broken. There are quite a few ARM people who would be happy to build test this and allow you to remove the "BROKEN" status on some of those. (I'm not one of them.)
Created attachment 232051 [details] multimedia/mkclean patch Looks like this is reproducible if you set SOURCE_DATE_EPOCH when you do `make package`. This patch is a little bit cleaner. If it looks good with you, I'm happy to see it land in main.
(In reply to rkoberman from comment #14) You're welcome! I appreciate your feedback. I think it'd be great to have people test on different architectures. I just have x86_64, although at some point I could probably setup a Raspberry Pi and test this on it. The old mkclean didn't support Opus audio streams and would remove them, but this newer version will preserve Opus which I think is great.
Build tests OK in 12.2{amd64,i386}, 13.0 amd64 and -current amd64. Also it seems to run OK in 13.0 amd64. So this LGTM. I'll commit it later today. Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a2c1dc5539c0d56d3766614f81e8d2ea1b480c85 commit a2c1dc5539c0d56d3766614f81e8d2ea1b480c85 Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2022-02-24 07:10:47 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-02-24 16:00:08 +0000 multimedia/mkclean: Update to 0.9.0 ChangeLog: https://github.com/Matroska-Org/foundation-source/blob/mkclean-0.9.0/mkclean/ChangeLog.txt PR: 262041 Reported by: sega01@go-beyond.org multimedia/mkclean/Makefile | 40 ++++++++++++---------- multimedia/mkclean/distinfo | 5 +-- ...corec__corec__helpers__file__file_libc.c (gone) | 11 ------ .../files/patch-corec__corec__portab.h (gone) | 12 ------- multimedia/mkclean/files/patch-root.proj (gone) | 10 ------ 5 files changed, 25 insertions(+), 53 deletions(-)
Committed, Thanks!