Bug 262061 - www/py-django-dpaste: Update to 3.5
Summary: www/py-django-dpaste: Update to 3.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL: https://github.com/DarrenOfficial/dpa...
Keywords:
Depends on: 261963 262060
Blocks: 261313
  Show dependency treegraph
 
Reported: 2022-02-20 11:10 UTC by Kai Knoblich
Modified: 2022-02-27 11:29 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+
kai: merge-quarterly-


Attachments
py-django-dpaste-3.5.patch (3.72 KB, patch)
2022-02-20 11:10 UTC, Kai Knoblich
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2022-02-20 11:10:34 UTC
Created attachment 231954 [details]
py-django-dpaste-3.5.patch

Hi Kubilay,

attached is the patch that updates www/py-django-dpaste to 3.5 and make it ready for Django 3.x .

Further changes to the port:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- Limit to Python <= 3.10 as the test suite fails with Python 3.11
- Modernize test suite
- Update WWW field as the upstream repository got a new maintainer

QA:
~~~
- poudriere -> OK (12.2-RELEASE amd64, py36, py37, py38, py39, py310)

Results via "make test":
~~~~~~~~~~~~~~~~~~~~~~~~

With Django 2.2 and Python 3.6-3.9:
> 50 passed in N.NN seconds

With Django 2.2 and Python 3.10 (with a local Pytest 7.0.1)
> 50 passed, 1 warning in N.NNs 

With Django 3.2 and Python 3.6-3.10 (Note: The dependency www/py-django-csp needs also to be switched to Django 3.2 in that case.):
> 50 passed, 10 warnings in N.NN seconds
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-22 00:16:01 UTC
Thanks Kai, looks good. 

1) Since setup.py 'test' is deprecated (setuptools, et al), are you able to switch this to use unittest directly? One of the following should just work:

- `python -m unittest -v` (shortcut for 'unittest discover')
- `python -m unittest -v tests`

2) Please include changelog link and MFH: <branch|No> <reason> in commit log message
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-22 00:16:41 UTC
Comment on attachment 231954 [details]
py-django-dpaste-3.5.patch

Modulo minor test target improvement:

Reviewed by: koobs (maintainer)
Approved by: koobs (maintainer)
MFH: ???
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-02-27 11:18:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f2333fd24eb4622ceb284368b1c84dc28903626a

commit f2333fd24eb4622ceb284368b1c84dc28903626a
Author:     Kai Knoblich <kai@FreeBSD.org>
AuthorDate: 2022-02-27 11:11:27 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2022-02-27 11:11:27 +0000

    www/py-django-dpaste: Update to 3.5

    * Set Python 3.10 as upper limit because there are incompatibilities
      with Python 3.11.

    * Update WWW field as the upstream repository got a new maintainer.

    Changelog:

    https://github.com/DarrenOfficial/dpaste/compare/v3.3.1...v3.5

    PR:             262061
    Approved by:    koobs (maintainer)
    MFH:            No (requires newer version of py-jsx-lexer)

 www/py-django-dpaste/Makefile                     | 23 +++++++++++++----------
 www/py-django-dpaste/distinfo                     |  6 +++---
 www/py-django-dpaste/files/patch-setup.cfg (gone) | 16 ----------------
 www/py-django-dpaste/pkg-descr                    |  2 +-
 4 files changed, 17 insertions(+), 30 deletions(-)
Comment 4 Kai Knoblich freebsd_committer freebsd_triage 2022-02-27 11:29:54 UTC
(In reply to Kubilay Kocak from comment #1)

Committed, thank you for your review and approval, Kubilay.  I also set the 'MFH' to '-' accordingly as noted in the commit message.