Bug 262104 - devel/highway: "Program received signal SIGILL, Illegal instruction." on Core 2 Duo (with upstream fix)
Summary: devel/highway: "Program received signal SIGILL, Illegal instruction." on Core...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL: https://github.com/google/highway/iss...
Keywords: crash
Depends on:
Blocks:
 
Reported: 2022-02-21 20:10 UTC by Vladimir Druzenko
Modified: 2022-03-06 14:28 UTC (History)
0 users

See Also:
jbeich: maintainer-feedback+
jbeich: merge-quarterly-

Attachments
Add upstream patch (1.05 KB, patch)
2022-02-21 20:34 UTC, Vladimir Druzenko 		vvd: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2022-02-21 20:10:58 UTC 
Details are at upstream's bug tracker: https://github.com/google/highway/issues/560

Can you add please this commit to port https://github.com/google/highway/commit/1ac50ad83d8cc1a0860d1e112d7046d16fe6f9b8 ?
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-02-21 20:22:29 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eec9ee622163d81127dd0841113c7c55e3cc0a85

commit eec9ee622163d81127dd0841113c7c55e3cc0a85
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-02-21 20:17:29 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-02-21 20:20:38 +0000

    devel/highway: backport crashfix for old CPUs

    PR:             262104
    Reported by:    VVD

 devel/highway/Makefile | 5 ++++-
 devel/highway/distinfo | 2 ++
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 2 Jan Beich freebsd_committer freebsd_triage 2022-02-21 20:27:30 UTC 
Thanks. If 0.15.0 on /quarterly (2022Q1) is affected I need a separate patch. Note, JXL by default (bug 261043, bug 262102, bug 262103) is limited to /latest (or 2022Q2).

$ make clean all
[...]
===>  Patching for highway-0.15.0_1
===>  Applying distribution patches for highway-0.15.0_1
2 out of 5 hunks failed--saving rejects to hwy/nanobenchmark.cc.rej
===>  FAILED Applying distribution patch 1ac50ad83d8c.patch with -p1
*** Error code 1
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2022-02-21 20:34:48 UTC 
Created attachment 231995 [details]
Add upstream patch

Tested on 12.3 amd64, Core 2 Duo E7200 and E6550.
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2022-02-21 20:36:06 UTC 
Oh!
You create patch before I attach my! :-D
Very fast!
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-22 22:44:00 UTC 
(In reply to VVD from comment #3)

Is quarterly affected?
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2022-02-22 23:48:08 UTC 
(In reply to Kubilay Kocak from comment #5)
Don't know - doesn't use quarterly.
Comment 7 Jan Beich freebsd_committer freebsd_triage 2022-02-23 01:12:42 UTC 
(In reply to Kubilay Kocak from comment #5)
Did you just ignore comment 2? Can you rebase upstream patch?
Comment 8 Jan Beich freebsd_committer freebsd_triage 2022-03-06 14:28:48 UTC 
Timeout.