Bug 262185 - audio/darkice: Delete libaacplus
Summary: audio/darkice: Delete libaacplus
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-02-25 04:06 UTC by takefu
Modified: 2022-03-01 15:34 UTC (History)
2 users (show)

See Also:

Attachments
darkice-1.4_2.patch (3.63 KB, patch)
2022-02-25 04:06 UTC, takefu 		no flags Details | Diff
darkice-1.4_2.patch2 (3.77 KB, patch)
2022-03-01 04:29 UTC, takefu 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2022-02-25 04:06:24 UTC 
Created attachment 232095 [details]
darkice-1.4_2.patch

Add CPE information
Delete audio/libaacplus
Fix files/darkice.in files/pkg-message.in
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-25 23:32:36 UTC 
Thank you for the report and patch

- What is the rationale for AACPLUS removal?
- Two options add libogg.so:audio/libogg as a dependency, what is the nature/why of this change?
Comment 2 Bernhard Froehlich freebsd_committer freebsd_triage 2022-02-27 10:02:06 UTC 
The CPE info does not exist in the CPE dictionary. It does not mean that it's wrong but do you have any confirmation that the CPE info is valid for this project? (like a previous CVE, some written statement etc.)
Comment 3 takefu 2022-03-01 04:29:47 UTC 
Created attachment 232177 [details]
darkice-1.4_2.patch2

(In reply to Kubilay Kocak from comment #1)

% grep libaacplus /usr/ports/MOVED
audio/libaacplus||2021-12-31|Has expired: Abandoned upstream, no new release since 2011

Audio/libogg The reason for addition is portlint(1) compliance.
====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/darkice is linked to /usr/local/lib/libogg.so.0 from audio/libogg but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libogg.so:audio/libogg
Error: /usr/local/bin/darkice is linked to /usr/local/lib/libsamplerate.so.0 from audio/libsamplerate but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libsamplerate.so:audio/libsamplerate

# cat /etc/make.conf
DEVELOPER=1


(In reply to Bernhard Froehlich from comment #2)
My mistake.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2022-03-01 09:38:06 UTC 
LGTM.

I'll commit this later today.

Thank you all.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-03-01 15:34:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3341ddfca4f9e59fb86c6519045d4c94adb13c02

commit 3341ddfca4f9e59fb86c6519045d4c94adb13c02
Author:     Kenji Takefu <takefu@airport.fm>
AuthorDate: 2022-03-01 08:01:11 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-03-01 15:32:02 +0000

    audio/darkice: Delete libaacplus

     * libaacplus has been abandoned
     * Add missing libogg dependency
     * Reporter becomes MAINTAINER

    PR:     262185
    Reported by:    takefu@airport.fm
    Reviewed by:    decke@ koobs@

 audio/darkice/Makefile             | 31 +++++++++++++++++--------------
 audio/darkice/files/darkice.in     |  3 ++-
 audio/darkice/files/pkg-message.in | 12 +++---------
 3 files changed, 22 insertions(+), 24 deletions(-)
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2022-03-01 15:34:30 UTC 
Committed,

Thanks!