Bug 262235 - [PATCH] mail/spampd: fails to start with spamassassin 3.4+
Summary: [PATCH] mail/spampd: fails to start with spamassassin 3.4+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Michael Gmelin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-27 19:57 UTC by Jonathan Chen
Modified: 2022-04-09 18:13 UTC (History)
1 user (show)

See Also:

Attachments
git-diff for mail/spampd (562 bytes, patch)
2022-02-27 19:57 UTC, Jonathan Chen 		no flags Details | Diff
rc-diff to work out-of-box (589 bytes, patch)
2022-03-03 22:29 UTC, Jonathan Chen 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Chen 2022-02-27 19:57:28 UTC 
Created attachment 232146 [details]
git-diff for mail/spampd

The out-of-box installation of mail/spampd fails with:

Feb 27 20:33:55 xxxxxx spampd[3876]: CONFIG ERROR! Option --auto-whitelist is deprecated with SpamAssassin v3.0+. Use SA configuration file instead.

I've added a patch to fix this, as well as changing the port-values to use values as suggested by the project at https://github.com/mpaperno/spampd/blob/master/spampd.pod#postfix-specific-notes
Comment 1 Jonathan Chen 2022-03-03 22:29:36 UTC 
Created attachment 232234 [details]
rc-diff to work out-of-box

Updated spampd flags to use directory writable by spamd/spamd, and remove obsoleted "--tagall"
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-04-09 18:00:43 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=adbaba0606ebeb620dc7425d43b8fe83a6eff08f

commit adbaba0606ebeb620dc7425d43b8fe83a6eff08f
Author:     Jonathan Chen <jonc@chen.org.nz>
AuthorDate: 2022-04-09 17:58:22 +0000
Commit:     Michael Gmelin <grembo@FreeBSD.org>
CommitDate: 2022-04-09 17:58:22 +0000

    mail/spampd: Unbreak with spamassassin 3.4+

    PR:             262235

 mail/spampd/Makefile        | 2 +-
 mail/spampd/files/spampd.in | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-04-09 18:02:45 UTC 
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=318255d4921caaf82c3c48d90bd9135d0ff41453

commit 318255d4921caaf82c3c48d90bd9135d0ff41453
Author:     Jonathan Chen <jonc@chen.org.nz>
AuthorDate: 2022-04-09 17:58:22 +0000
Commit:     Michael Gmelin <grembo@FreeBSD.org>
CommitDate: 2022-04-09 18:01:23 +0000

    mail/spampd: Unbreak with spamassassin 3.4+

    PR:             262235
    (cherry picked from commit adbaba0606ebeb620dc7425d43b8fe83a6eff08f)

 mail/spampd/Makefile        | 2 +-
 mail/spampd/files/spampd.in | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
Comment 4 Michael Gmelin freebsd_committer freebsd_triage 2022-04-09 18:12:49 UTC 
@Jonathan Thanks for providing the patch.

One thing I noticed while testing: If AWL is enabled in spamassassin (in v310.pre), `/var/spool/spamd/auto-whitelist` is created as owned by root:spamd (0600) when starting spampd, which means that spampd probably can't write to it.

This can be fixed by manually running chmod on the file (this stays stable on restart).