Bug 262513 - math/oink: update and make atomics portable
Summary: math/oink: update and make atomics portable
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-12 23:45 UTC by Robert Clausecker
Modified: 2022-03-31 19:55 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
math/oink: update and make atomics portable (3.60 KB, patch)
2022-03-12 23:45 UTC, Robert Clausecker 		fuz: maintainer-approval? (yuri)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-03-12 23:45:51 UTC 
Created attachment 232413 [details]
math/oink: update and make atomics portable

The attached patch replaces the mfence() macro with something that should work on any architecture.  Unfortunately upstream doesn't seem to understand atomics and uses volatile variables instead, so it's still somewhat of a fingers crossed situation.

I've also took the liberty to advance the port to the current commit which integrates the two patches you have.

Tested with Poudriere on armv7 arm64 FreeBSD 13.  The testsuite passes on armv7 except for the following 3 cases:

	  6 - TestSolverPSIp (Bus error)
	 27 - TestSolverZLKpar (Bus error)
	 29 - TestSolverUZLK (Bus error)

Looks like an unaligned memory access maybe.  On arm64 there are no errors.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2022-03-13 02:27:34 UTC 
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-03-13 02:27:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=de445d5dd99c6b2d2188f7f25d41c871a14e12db

commit de445d5dd99c6b2d2188f7f25d41c871a14e12db
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-03-13 02:26:31 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-03-13 02:27:25 +0000

    math/oink: Update g20210704 -> g20210710 and make atomics portable

    PR:             262513

 math/oink/Makefile               |  9 ++-------
 math/oink/distinfo               | 10 +++-------
 math/oink/files/patch-src_lace.h | 25 +++++++++++++++++++------
 3 files changed, 24 insertions(+), 20 deletions(-)
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-03-31 19:55:19 UTC 
Somehow this PR failed to be closed.