Bug 262656 - emulators/virtualbox-ose-kmod: Fix kernel panic when VM assigns DHCP IP via bridge mode.
Summary: emulators/virtualbox-ose-kmod: Fix kernel panic when VM assigns DHCP IP via b...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Virtualbox Team (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-18 23:12 UTC by Neel Chauhan
Modified: 2025-01-04 15:27 UTC (History)
3 users (show)

See Also:
madpilot: maintainer-feedback+

Attachments
Patch (Revision 1) (6.50 KB, patch)
2022-03-18 23:12 UTC, Neel Chauhan 		no flags Details | Diff
VirtualBox crash log (266.42 KB, text/plain)
2022-03-18 23:13 UTC, Neel Chauhan 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neel Chauhan freebsd_committer freebsd_triage 2022-03-18 23:12:42 UTC 
Created attachment 232561 [details]
Patch (Revision 1)

This patch fixes a kernel panic when a VM attempts to assign an IP address via DHCP.

I will attach the crash log shortly.
Comment 1 Neel Chauhan freebsd_committer freebsd_triage 2022-03-18 23:13:07 UTC 
Created attachment 232562 [details]
VirtualBox crash log

Here's the coredump/crash log.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2022-03-19 10:53:24 UTC 
I'll take a look.

Strangely I have never experienced this panic myself.

Anyway the patch looks correct. I just want to test it a little before commit.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-03-19 19:21:01 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b1d24b891bbadf165edf477b98d61d407144208c

commit b1d24b891bbadf165edf477b98d61d407144208c
Author:     Neel Chauhan <nc@FreeBSD.org>
AuthorDate: 2022-03-19 19:18:19 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-03-19 19:19:59 +0000

    emulators/virtualbox-ose-kmod: Fix kernel panic in DHCP bridge mode

    PR:             262656
    Approved by:    madpilot

 emulators/virtualbox-ose-kmod/Makefile             |  1 +
 ...Drivers_VBoxNetFlt_freebsd_VBoxNetFlt-freebsd.c | 40 ++++++++++++++--------
 2 files changed, 26 insertions(+), 15 deletions(-)
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2022-03-19 19:38:19 UTC 
I'm reopening this due to the fact that I noticed the legacy version also needs the same patch.

Going to commit it shortly.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-03-19 19:44:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c3c1502372cad26671f7550d0e54d2cc77e47b3a

commit c3c1502372cad26671f7550d0e54d2cc77e47b3a
Author:     Neel Chauhan <nc@FreeBSD.org>
AuthorDate: 2022-03-19 19:42:02 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2022-03-19 19:42:02 +0000

    emulators/virtualbox-ose-kmod-legacy: Fix kernel panic in DHCP bridge mode

    PR:             262656

 emulators/virtualbox-ose-kmod-legacy/Makefile      |  2 +-
 ...Drivers_VBoxNetFlt_freebsd_VBoxNetFlt-freebsd.c | 40 ++++++++++++++--------
 2 files changed, 26 insertions(+), 16 deletions(-)
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2022-03-19 19:44:34 UTC 
Thanks!