Created attachment 232587 [details] py-django-hijack-3.1.4.patch Hi, attached is the patch that updates www/py-django-hijack to 3.1.4. There's already 3.1.6 out there but that release has a regression introduced in 3.1.5 (see PR #423). The 3.x release requires "gettext" and "npm" to build the package thus a few lines in the Makefile contain some significant changes. Because "npm" is used there's also the need to use a offline cache otherwise "npm" will try to fetch its dependencies during the build phase which isn't supported/allowed. At the moment the tarball of the "npm" cache is provided via my public distfile directory at the FreeBSD cluster. It would be great if you can host the npm cache at a server you own. There's also a "make-npm-cache" target which should make the generation of the npm cache easier for future releases of www/py-django-hijack. P.S.: I did a mistake with ports c45d55461ce5 (= deprecation of www/py-django-compat) because I overlooked that you're maintainer of that port. I hope it's ok otherwise please let know if I should revert that commit. QA: ~~~ poudriere -> OK (12.2-RELEASE amd64 for py37, py38, py39) Results via "make test" (py37-py39): ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ==== 57 passed in N.NN seconds ====
Thanks for the update - I got waylaid on this one. The www/py-django-compat deprecation is fine, it's a redundant port once this updates. I'm happy hosting the cache and have copied the files over ready to go, I'll update the patch and submit with a new distfile. Many thanks for the "make-npm-cache" hook - that's going to be a useful timesaver going forward.
Created attachment 232635 [details] Updated MASTER_SITES for npm-cache hosting
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=49cc694155ed62fc2163b201a1de9d832964af05 commit 49cc694155ed62fc2163b201a1de9d832964af05 Author: Kai Knoblich <kai@FreeBSD.org> AuthorDate: 2022-03-25 16:00:04 +0000 Commit: Kai Knoblich <kai@FreeBSD.org> CommitDate: 2022-03-25 16:07:58 +0000 www/py-django-hijack: Update to 3.1.4 Changelog since 2.1.10: https://github.com/django-hijack/django-hijack/compare/v2.1.10...3.1.4 PR: 262678 Approved by: Kevin Golding (maintainer) www/py-django-hijack/Makefile | 44 +++++++++++++++++++++---- www/py-django-hijack/distinfo | 8 +++-- www/py-django-hijack/files/patch-setup.py (new) | 35 ++++++++++++++++++++ 3 files changed, 78 insertions(+), 9 deletions(-)
Comment on attachment 232587 [details] py-django-hijack-3.1.4.patch ^Triage: Set initial patch as obsolete.
(In reply to Kevin Golding from comment #1) Committed, thank you Kevin, for your review, approval and the hosting of the npm cache!