Bug 262692 - net-im/py-matrix-synapse: rc.d script doesn't use synapse_user variable in start_precmd
Summary: net-im/py-matrix-synapse: rc.d script doesn't use synapse_user variable in st...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-20 22:50 UTC by Marcin Gryszkalis
Modified: 2022-03-26 15:52 UTC (History)
3 users (show)

See Also:
ports: maintainer-feedback+
ashish: merge-quarterly+


Attachments
patch: fix owner to match synapse_user (677 bytes, patch)
2022-03-20 22:50 UTC, Marcin Gryszkalis
no flags Details | Diff
net-im/py-matrix-synapse: improve rc script (977 bytes, patch)
2022-03-26 12:41 UTC, Sascha Biberhofer
ports: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Gryszkalis 2022-03-20 22:50:42 UTC
Created attachment 232595 [details]
patch: fix owner to match synapse_user

It has hardcoded "install -d -o synapse", patch attached
Comment 1 Sascha Biberhofer 2022-03-26 12:41:11 UTC
Created attachment 232732 [details]
net-im/py-matrix-synapse: improve rc script

Good catch! In fact, we can clean this up a bit more, as the last check is a noop since we no longer ship a sample configuration that needs changing. I've updated your diff a bit to include that, which is good to go from my end. :-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-03-26 15:45:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6e79c8a26861c23f9604b926d80f86412139bde0

commit 6e79c8a26861c23f9604b926d80f86412139bde0
Author:     Sascha Biberhofer <ports@skyforge.at>
AuthorDate: 2022-03-26 12:49:11 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2022-03-26 15:44:32 +0000

    net-im/py-matrix-synapse: Fix rc.d script

    rc.d script doesn't use synapse_user variable in start_precmd

    PR:             262692
    Reported by:    Marcin Gryszkalis <mg at fork dot pl>

 net-im/py-matrix-synapse/files/synapse.in | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-03-26 15:51:57 UTC
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=82c90ab7afce7accb3f502e4587a46f76642c74b

commit 82c90ab7afce7accb3f502e4587a46f76642c74b
Author:     Sascha Biberhofer <ports@skyforge.at>
AuthorDate: 2022-03-26 12:49:11 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2022-03-26 15:48:41 +0000

    net-im/py-matrix-synapse: Fix rc.d script

    rc.d script doesn't use synapse_user variable in start_precmd

    PR:             262692
    Reported by:    Marcin Gryszkalis <mg at fork dot pl>

    (cherry picked from commit 6e79c8a26861c23f9604b926d80f86412139bde0)

 net-im/py-matrix-synapse/files/synapse.in | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2022-03-26 15:52:38 UTC
Committed, thanks.