Bug 262705 - devel/libffi distinfo broken now due to github commitid lengthening for auto-diff creation
Summary: devel/libffi distinfo broken now due to github commitid lengthening for auto-...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kevin Bowling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-21 17:32 UTC by thetanix
Modified: 2022-05-03 15:14 UTC (History)
2 users (show)

See Also:
kbowling: maintainer-feedback+
kbowling: merge-quarterly+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description thetanix 2022-03-21 17:32:13 UTC 
devel/libffi distinfo refers to a github .diff which uses a commitid shorter than the one github is currently feeding out. I guess some other commitid collided with it perhaps and so it auto-lengthened.

01a75ed76ea7e57f1b7a5c183e2b1e890e6aa0fd.diff will no longer match when pulled from github, here:

https://github.com/libffi/libffi/commit/01a75ed76ea7e57f1b7a5c183e2b1e890e6aa0fd.diff

The diff to the "new" commitid diff is:

diff 01a75ed76ea7e57f1b7a5c183e2b1e890e6aa0fd.diff*
2c2
< index 5ee2a709..8e2f2f0e 100644
---
> index 5ee2a7095..8e2f2f0e7 100644

This is breaking a pile of ports which depend on libffi.
Comment 1 Rene Ladan freebsd_committer freebsd_triage 2022-05-02 10:50:21 UTC 
Maintainer reset.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-05-03 15:10:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3961f81d9b62b2e94fcd27965c94d908b3dc6793

commit 3961f81d9b62b2e94fcd27965c94d908b3dc6793
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2022-05-03 15:06:46 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2022-05-03 15:09:12 +0000

    devel/libffi: Fix distinfo for GitHub patch

    GitHub is now generating a longer short commit ID in the patch.

    PR:             262705
    Reported by:    thetanix (thetanix@gmail.com)
    MFH:            2022Q2
    Sponsored by:   BBOX.io

 devel/libffi/distinfo | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-05-03 15:12:08 UTC 
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=011bfe906b6aec61b2ca31aa1ebdefc1cb66ea63

commit 011bfe906b6aec61b2ca31aa1ebdefc1cb66ea63
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2022-05-03 15:06:46 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2022-05-03 15:10:37 +0000

    devel/libffi: Fix distinfo for GitHub patch

    GitHub is now generating a longer short commit ID in the patch.

    PR:             262705
    Reported by:    thetanix (thetanix@gmail.com)
    Sponsored by:   BBOX.io

    (cherry picked from commit 3961f81d9b62b2e94fcd27965c94d908b3dc6793)

 devel/libffi/distinfo | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 4 Kevin Bowling freebsd_committer freebsd_triage 2022-05-03 15:14:28 UTC 
(In reply to thetanix from comment #0)
Thanks for the report!