Created attachment 232637 [details] Patch for tcpslice Use upstream release archive as recommended by Porters Handbook (USE_GITHUB section) Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist) Poudriere testport OK 12.2-RELEASE (amd64) Poudriere testport OK 13.0-RELEASE (i386)
Hi Daniel, It was already like that before, I switched it to GitHub on purpose as the-tcpdump-group organization was created with all the projects. I don't see the added value of this patch. Let's keep it how it is. Lot of ports in the framework are using GitHub as source of truth and it's good enough for us. I don't intent to change that at least since a new release because I will have to MFH my last changes, thanks.
Hi, I admit that recommends is incorrect phrasing on my end, it clearly states that it's the last resort (see below). The value is both that you ensure that the port doesn't get broken due to changes on how GitHub packages repos (as these archives are generated on the fly), smaller size (negligible in this case), easier to verify integrity and consistency. You may not personally agree with Porters Handbook but we should really try to be as consistent as possible as that makes it easier for everyone in the end and we are actively working on that. This is from that mentioned section: "If the distribution file comes from a specific commit or tag on GitHub for which there is no officially released file" Best regards, Daniel
Hi Daniel, I think it's just nit, consistency and integrity are handled in the b.p.m with the distinfo checks. Did you realize the amount of fetch from GitHub we are doing in the ports tree ? Even pkg is using GitHub archives. That's said, I think we can close this bug or eventually switch it to next release but I'm not too keen for that. Let's focus on what really matters.
Created attachment 239345 [details] Patch for tcpslice v2 Compile tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist) Poudriere testport OK 12.3-RELEASE (amd64) Poudriere testport OK 13.1-RELEASE (i386)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7c9bb96a4724df3bf42b1005f9cd6d84c581147f commit 7c9bb96a4724df3bf42b1005f9cd6d84c581147f Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2023-01-28 11:07:29 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2023-01-28 11:07:35 +0000 net/tcpslice: Update to 1.6 and use upstream release archive Changelog: https://github.com/the-tcpdump-group/tcpslice/blob/tcpslice-1.6/CHANGES PR: 262723 Approved by: portmgr (maintainer timeout, 2+ weeks) net/tcpslice/Makefile | 7 ++----- net/tcpslice/distinfo | 6 +++--- 2 files changed, 5 insertions(+), 8 deletions(-)