Bug 262874 - audio/libmad: Update to 0.16.0
Summary: audio/libmad: Update to 0.16.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://github.com/tenacityteam/libma...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-28 01:37 UTC by Daniel Engberg
Modified: 2022-06-04 08:51 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch for libmad (10.35 KB, patch)
2022-03-28 01:37 UTC, Daniel Engberg 		no flags Details | Diff
Patch for libmad (10.35 KB, patch)
2022-03-30 21:59 UTC, Daniel Engberg 		no flags Details | Diff
Patch for libmad v3 (10.35 KB, patch)
2022-03-30 22:02 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-03-28 01:37:23 UTC 
Created attachment 232766 [details]
Patch for libmad

Switch to Tenacity's fork which contains patched code for all known CVEs and various build fixes. This also makes it easier to maintain as we're using an active fork. Upstream has also switched to CMake.

Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 13.0-RELEASE (i386)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-03-28 01:39:00 UTC 
pkubaj, can you have a look on PPC?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-03-30 19:31:09 UTC 
There's one pending PR upstream for i386 optimization, I'll update patch once that's accepted upstream
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2022-03-30 20:06:40 UTC 
Seems ok on powerpc and powerpc64.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-03-30 21:59:34 UTC 
Created attachment 232831 [details]
Patch for libmad

Use upstream commits
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-03-30 22:02:49 UTC 
Created attachment 232832 [details]
Patch for libmad v3

Attach correct patch
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2022-03-31 11:02:41 UTC 
(In reply to Piotr Kubaj from comment #3)
Great, thanks!
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2022-03-31 19:46:58 UTC 
I should also add that the backported patches fixes identification of x86 for both 32-bit and 64-bit on FreeBSD
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-05-06 10:00:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=519c89efe3a9ddc8f3a57d1bb4940ff355086576

commit 519c89efe3a9ddc8f3a57d1bb4940ff355086576
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-05-06 09:47:30 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-05-06 09:59:33 +0000

    audio/libmad: Update to 0.16.0

    Switch to Tenacity's fork which contains patched code for all known CVEs
    and various build fixes. This also makes it easier to maintain as we're
    using an active fork. Upstream has also switched to CMake.

    PR:             262874
    Approved by:    sunpoet (maintainer timeout 4+ weeks)

 audio/libmad/Makefile                     |  30 ++---
 audio/libmad/distinfo                     |   9 +-
 audio/libmad/files/mad.pc.in (gone)       |  11 --
 audio/libmad/files/patch-configure (gone) |  40 -------
 audio/libmad/files/patch-layer12.c (gone) | 175 ------------------------------
 audio/libmad/files/patch-layer3.c (gone)  |  17 ---
 audio/libmad/pkg-plist                    |  10 +-
 7 files changed, 23 insertions(+), 269 deletions(-)
Comment 9 Charlie Li freebsd_committer freebsd_triage 2022-05-06 21:53:16 UTC 
Also commenting here for more visibility: this broke at least sysutils/mtpfs and audio/audacity because those build systems now cannot detect this library. Side note, Audacity has their own fork of this library.
Comment 10 Daniel Engberg freebsd_committer freebsd_triage 2022-05-06 22:43:39 UTC 
Looking into it, thanks for reporting