Bug 263023 - multimedia/smpeg: revert accidental (?) configure patch
Summary: multimedia/smpeg: revert accidental (?) configure patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-02 23:38 UTC by Robert Clausecker
Modified: 2022-06-19 01:21 UTC (History)
2 users (show)

See Also:
fuz: maintainer-feedback-
fuz: merge-quarterly?

Attachments
acm@freebsd.org (2.12 KB, patch)
2022-04-02 23:38 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-04-02 23:38:07 UTC 
Created attachment 232912 [details]
acm@freebsd.org

Commit 87624aab for PR #231524 has accidentally introduced two
additional patches to the configure script, breaking parts of
its workings.  Revert these changes to fix the configuration.

Tested with Poudriere on armv7 arm64 FreeBSD 13.
Please MFH if possible.

Also consider updating smpeg to version 2.0.0 released by the new upstream
https://github.com/icculus/smpeg.  If desired, I can volunteer a patch.

This change is important because the accidental configure patch caused errors during cross compilation like these:

===>  Building for smpeg-0.4.4_15
gmake[1]: Entering directory '/wrkdirs/usr/ports/multimedia/smpeg/work/smpeg-0.4.4'
Making all in audio
gmake[2]: Entering directory '/wrkdirs/usr/ports/multimedia/smpeg/work/smpeg-0.4.4/audio'
/usr/local/bin/libtool --mode=compile /nxb-bin/usr/bin/c++ -DPACKAGE=\"smpeg\" -DVERSION=\"0.4.4\"  -I. -I.      -O2 -pipe  -Wno-c++11-narrowing -fstack-protector-strong -fno-strict-aliasing  -I/usr/local/include/SDL -I/usr/local/include -D_REENTRANT -D_THREAD_SAFE -DTHREADED_AUDIO -DNDEBUG -I.. -DNOCONTROLS -I.. -I../audio -I../video -fno-exceptions -fno-rtti -c MPEGaudio.cpp
libtool: compile: unable to infer tagged configuration
libtool:   error: specify a tag with '--tag'
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-04-19 15:20:17 UTC 
maintainer timeout
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-06-13 14:51:09 UTC 
Comment on attachment 232912 [details]
acm@freebsd.org

Maintainer timeout on patch
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-06-18 06:36:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=907bea97e142d2599363cfcf19b7b40504fa69e6

commit 907bea97e142d2599363cfcf19b7b40504fa69e6
Author:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
AuthorDate: 2022-06-18 06:28:04 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2022-06-18 06:28:04 +0000

    multimedia/smpeg: Revert configure patch file

    * Commit 87624aab for PR #231524 has accidentally introduced two
      additional patches to the configure script, breaking parts of
      its workings.  Revert these changes to fix the configuration.
    * Bump PORTREVISION
    PR:             263023
    Reported by:    Robert Clausecker <fuz  _at_  fuz.su>

 audio/sdl_mixer/Makefile               |  2 +-
 audio/sdl_sound/Makefile               |  2 +-
 devel/p5-SDL/Makefile                  |  2 +-
 devel/py-game/Makefile                 |  1 +
 games/battletanks/Makefile             |  2 +-
 games/fillets-ng/Makefile              |  2 +-
 games/heroes/Makefile                  |  2 +-
 games/onscripter/Makefile              |  1 +
 games/prboom-plus/Makefile             |  2 +-
 games/prboom/Makefile                  |  2 +-
 games/rnd_jue/Makefile                 |  2 +-
 games/rocksndiamonds/Makefile          |  2 +-
 games/tecnoballz/Makefile              |  2 +-
 multimedia/dumpmpeg/Makefile           |  2 +-
 multimedia/smpeg/Makefile              |  2 +-
 multimedia/smpeg/files/patch-configure | 26 --------------------------
 x11-fm/tdfsb/Makefile                  |  2 +-
 17 files changed, 16 insertions(+), 40 deletions(-)
Comment 4 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2022-06-18 06:37:01 UTC 
Committed thanks! Btw smpeg 2.0.0 is part of FreeBSD ports tree. Take a look at multimedia/smpeg2
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2022-06-19 01:21:18 UTC 
(In reply to Jose Alonso Cardenas Marquez from comment #4)

Thanks for mentioning this!  I was unaware.  I only found this problem because I was building all ports and checked for build errors for armv7, then I saw that an update was available and left a quick note.  I'm not even a user of this port.