Created attachment 232945 [details] deskutils/remind: update to 04.00.00 A feature release. Relevant upstream changes: - Remind output can effectively be translated into other languages at run-time. - Add the pad() built-in function - Day numbers can be displayed left-aligned, centered or right-aligned. - Print better diagnostics when errors occur inside a user-defined function. - Add a "q" sub-option to the "-p", "-pp", and "-ppp" options. - tkremind: Fix the "-m" flag, which was broken in 03.04.00. - Warn if the arguments to the "-@" option are out of range. - Always interpret $Latitude and $Longitude input values in the "C" locale. - Fix many spelling mistakes Following the deprectation of the LANGUAGE compile time option, we are going to discontinue it at some point in the future. Tested with Poudriere on armv7 arm64 FreeBSD 13. Do not MFH this feature release.
Q/A: Makefile: [23]: use a tab (not space) after a variable name ^Triage: Please confirm this change passes QA (portlint, poudriere at least). No need to update a new patch. Just try to use portlint and/or portclippy. They catch many things!
(In reply to Fernando Apesteguía from comment #1) Hi, this is a spurious warning referring to the line OPTIONS_SINGLE_LANGUAGE= \ LANG_US LANG_DE LANG_NL LANG_FI LANG_FR LANG_NN LANG_DA \ LANG_PL LANG_PBR LANG_IT LANG_RO LANG_ES LANG_IS I had used a space istead of a tab as a line break immediately follows. You can change this if desired.
(In reply to Fernando Apesteguía from comment #1) The version of portlint I have installed (2.19.9) does not warn about this issue for some reason, interestingly enough.
(In reply to Robert Clausecker from comment #3) Thanks for double checking. I would change it so to get rid of it. Respecting line length and all. Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=09788e44fe214cd0035c04c57454f6c268ded40e commit 09788e44fe214cd0035c04c57454f6c268ded40e Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-04-05 08:05:15 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-04-05 13:46:02 +0000 deskutils/remind: update to 04.00.00 From ChangeLog: https://git.skoll.ca/Skollsoft-Public/Remind/src/branch/master/docs/WHATSNEW * Remind output can effectively be translated into other languages at run-time. * Add the pad() built-in function * Day numbers can be displayed left-aligned, centered or right-aligned. * Print better diagnostics when errors occur inside a user-defined function. * Add a "q" sub-option to the "-p", "-pp", and "-ppp" options. * tkremind: Fix the "-m" flag, which was broken in 03.04.00. * Warn if the arguments to the "-@" option are out of range. * Always interpret $Latitude and $Longitude input values in the "C" locale. * Fix many spelling mistakes PR: 263049 Reported by: fuz@fuz.su (maintainer) deskutils/remind/Makefile | 8 ++++---- deskutils/remind/distinfo | 6 +++--- deskutils/remind/pkg-plist | 17 +++++++++++++++++ 3 files changed, 24 insertions(+), 7 deletions(-)
Committed, Thanks!
(In reply to Fernando Apesteguía from comment #6) Ah, you removed the most important part of the commit message (notice of deprecation for the LANGUAGE option). Please consider not butchering the commit messages. I take great care to make them as useful as possible to the user.
(In reply to Robert Clausecker from comment #7) Arg, sorry for that. I went blindly for the bullet points. Apologies.