Bug 263053 - www/h2o: Fix build with Ruby 3.x when MRUBY option is enabled
Summary: www/h2o: Fix build with Ruby 3.x when MRUBY option is enabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yasuhiro Kimura
URL:
Keywords:
Depends on:
Blocks: 262350
  Show dependency tree / graph
 
Reported: 2022-04-05 02:24 UTC by Yasuhiro Kimura
Modified: 2022-04-27 18:29 UTC (History)
2 users (show)

See Also:
dch: maintainer-feedback+

Attachments
Patch file (1.21 KB, patch)
2022-04-05 02:24 UTC, Yasuhiro Kimura 		no flags Details | Diff
fix build with ruby3 (3.22 KB, patch)
2022-04-23 12:13 UTC, Florian Smeets 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2022-04-05 02:24:11 UTC 
Created attachment 232949 [details]
Patch file

cd /wrkdirs/usr/ports/www/h2o/work/h2o-2.2.6/deps/mruby && MRUBY_TOOLCHAIN=clang MRUBY_CONFIG=/wrkdirs/usr/ports/www/h2o/work/h2o-2.2.6/misc/mruby_config.rb  RUBY_BUILD_DIR=/wrkdirs/usr/ports/www/h2o/work/.build/mruby ruby minirake (in /wrkdirs/usr/ports/www/h2o/work/h2o-2.2.6/deps/mruby)
PKG-CONFIG onigmo
PKG-CONFIG oniguruma
rake aborted!
wrong number of arguments (given 2, expected 1)
Rakefile:40:in `<top (required)>'
*** Error code 1

Stop.
Comment 1 Yasuhiro Kimura freebsd_committer freebsd_triage 2022-04-20 06:58:06 UTC 
Maintainer timeout. Take.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-04-20 07:00:43 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3599bedde4d4b228ece36c67ff78974e37347f43

commit 3599bedde4d4b228ece36c67ff78974e37347f43
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2022-04-04 14:58:46 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2022-04-20 06:56:56 +0000

    www/h2o: Mark BROKEN with Ruby 3.x when MRUBY option is enabled

    cd /wrkdirs/usr/ports/www/h2o/work/h2o-2.2.6/deps/mruby && MRUBY_TOOLCHAIN=clang MRUBY_CONFIG=/wrkdirs/usr/ports/www/h2o/work/h2o-2.2.6/misc/mruby_config.rb MRUBY_BUILD_DIR=/wrkdirs/usr/ports/www/h2o/work/.build/mruby ruby minirake
    (in /wrkdirs/usr/ports/www/h2o/work/h2o-2.2.6/deps/mruby)
    PKG-CONFIG onigmo
    PKG-CONFIG oniguruma
    rake aborted!
    wrong number of arguments (given 2, expected 1)
    Rakefile:40:in `<top (required)>'
    *** Error code 1

    Stop.

    PR:             263053
    Approved by:    maintainer timeout

 www/h2o/Makefile | 7 +++++++
 1 file changed, 7 insertions(+)
Comment 3 Florian Smeets freebsd_committer freebsd_triage 2022-04-23 12:13:25 UTC 
Created attachment 233419 [details]
fix build with ruby3

Fix build with ruby 3. I saw https://github.com/h2o/h2o/issues/2789 and adapted it for our port. With the attached patch I can build www/h2o and dns/dnsdist which depends on h2o, again.
Comment 4 Yasuhiro Kimura freebsd_committer freebsd_triage 2022-04-23 14:15:48 UTC 
Ask for maintainer's feedback about attachment 233419 [details].
Comment 5 Dave Cottlehuber freebsd_committer freebsd_triage 2022-04-27 07:24:48 UTC 
LGTM, thanks Yasuhiro!
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-04-27 07:33:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8272d84a122f4169c06d794415d598a8b965b43e

commit 8272d84a122f4169c06d794415d598a8b965b43e
Author:     Florian Smeets <flo@FreeBSD.org>
AuthorDate: 2022-04-23 14:32:45 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2022-04-27 07:32:14 +0000

    www/h2o: Fix build with Ruby 3.x when MRUBY option is enabled

    Reference:      https://github.com/h2o/h2o/issues/2789
    PR:             263053
    Approved by:    maintainer

 www/h2o/Makefile                              |  7 ---
 www/h2o/files/patch-deps_mruby_Rakefile (new) | 63 +++++++++++++++++++++++++++
 2 files changed, 63 insertions(+), 7 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-04-27 18:29:00 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eba7baa6aed1ae7b727d66abc51fb77bdd81b963

commit eba7baa6aed1ae7b727d66abc51fb77bdd81b963
Author:     Florian Smeets <flo@FreeBSD.org>
AuthorDate: 2022-04-27 18:22:58 +0000
Commit:     Florian Smeets <flo@FreeBSD.org>
CommitDate: 2022-04-27 18:22:58 +0000

    www/h2o-devel: Fix build with Ruby 3.x when MRUBY option is enabled

    Apply a simillar patch as in 8272d84a122f for www/h2o.

    Reference:      https://github.com/h2o/h2o/issues/2789
    PR:             263053

 www/h2o-devel/files/patch-deps_mruby_Rakefile (new) | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)