Bug 263055 - irc/weechat - missing dependency after update to 3.5?
Summary: irc/weechat - missing dependency after update to 3.5?
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernard Spil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-05 08:18 UTC by Herbert J. Skuhra
Modified: 2022-04-05 09:20 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (brnrd)


Attachments
Add archivers/zstd dependency (494 bytes, patch)
2022-04-05 08:18 UTC, Herbert J. Skuhra
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Herbert J. Skuhra 2022-04-05 08:18:39 UTC
Created attachment 232953 [details]
Add archivers/zstd dependency

Weechat fails to build on my amd64/arm64 systems:

-- Checking for module 'libzstd'
--   Package 'libzstd', required by 'virtual:world', not found
CMake Error at cmake/FindPkgConfig.cmake:463 (message):
  A required package was not found
Call Stack (most recent call first):
  cmake/FindPkgConfig.cmake:643 (_pkg_check_modules_internal)
  CMakeLists.txt:205 (pkg_check_modules)

With the attached patch it works.

I have no idea why 'pkg install weechat' automatically installs zstd and why there is no pkg-fallout notification.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-04-05 08:59:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=728549dd3a761cff6623aac7a562d01eb742c0d7

commit 728549dd3a761cff6623aac7a562d01eb742c0d7
Author:     Bernard Spil <brnrd@FreeBSD.org>
AuthorDate: 2022-04-05 08:57:17 +0000
Commit:     Bernard Spil <brnrd@FreeBSD.org>
CommitDate: 2022-04-05 08:57:17 +0000

    irc/weechat: Add zstd dependency

     * 3.5 requires zstd https://github.com/weechat/weechat/commit/498194f6

    PR:             263055
    Reported by:    Herbert J. Skuhra <herbert gojira at>

 irc/weechat/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-04-05 09:20:37 UTC
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2f1d107339794b7dccd907ee800888f847daced6

commit 2f1d107339794b7dccd907ee800888f847daced6
Author:     Bernard Spil <brnrd@FreeBSD.org>
AuthorDate: 2022-04-05 08:57:17 +0000
Commit:     Bernard Spil <brnrd@FreeBSD.org>
CommitDate: 2022-04-05 09:11:14 +0000

    irc/weechat: Add zstd dependency

     * 3.5 requires zstd https://github.com/weechat/weechat/commit/498194f6

    PR:             263055
    Reported by:    Herbert J. Skuhra <herbert gojira at>

    (cherry picked from commit 728549dd3a761cff6623aac7a562d01eb742c0d7)

 irc/weechat/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)