Bug 263058 - sysutils/pefs-kmod: Update to work on FreeBSD 13.1-RC1
Summary: sysutils/pefs-kmod: Update to work on FreeBSD 13.1-RC1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-05 11:35 UTC by Daniel O'Connor
Modified: 2022-09-24 11:56 UTC (History)
4 users (show)

See Also:


Attachments
Patch to update port (1.21 KB, patch)
2022-04-05 11:35 UTC, Daniel O'Connor
darius: maintainer-approval+
Details | Diff
Update port (1.57 KB, patch)
2022-08-16 13:09 UTC, Daniel O'Connor
darius: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel O'Connor 2022-04-05 11:35:21 UTC
Created attachment 232956 [details]
Patch to update port

This updates to a version with fixes for various KABI changes in FreeBSD 13+.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-04-07 06:21:16 UTC
Thanks for the patch.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]
Comment 2 Daniel O'Connor 2022-08-13 12:44:20 UTC
Sorry, belatedly realised I hadn't marked the patch as OK.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-08-16 12:23:46 UTC
This only works in 13.1 amd64 (and maybe in i386 although it is not tier 1 anymore).

It fails to build in 12.3 both amd64 and i386
...
ity -Wno-error=unused-function -Wno-error=pointer-sign -Wno-error=shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length  -mno-aes -mno-avx  -std=iso9899:1999 -c /wrkdirs/usr/ports/sysutils/pefs-kmod/work/pefs-4871d25/sys/modules/pefs/../../fs/pefs/pefs_vnops.c -o pefs_vnops.o
/wrkdirs/usr/ports/sysutils/pefs-kmod/work/pefs-4871d25/sys/modules/pefs/../../fs/pefs/pefs_vnops.c:2195:3: error: implicit declaration of function 'vm_page_busy_acquire' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                vm_page_busy_acquire(m, VM_ALLOC_SBUSY);
                ^
/wrkdirs/usr/ports/sysutils/pefs-kmod/work/pefs-4871d25/sys/modules/pefs/../../fs/pefs/pefs_vnops.c:2495:3: error: implicit declaration of function 'vm_page_busy_acquire' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                vm_page_busy_acquire(m, VM_ALLOC_SBUSY);
                ^
2 errors generated.
*** Error code 1

Stop.
make[2]: stopped in /wrkdirs/usr/ports/sysutils/pefs-kmod/work/pefs-4871d25/sys/modules/pefs
*** Error code 1
*** Error code 1
Comment 4 Daniel O'Connor 2022-08-16 13:09:30 UTC
Created attachment 235940 [details]
Update port

Updates to 7e65358 to fix build on 12.
Comment 5 Daniel O'Connor 2022-08-16 13:10:00 UTC
There was a typo upstream which I have fixed and updated the port patch.
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2022-08-16 15:58:14 UTC
Committed,

Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-08-16 15:58:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=79f9679c7e795de9a15451910526cea3ea50c21f

commit 79f9679c7e795de9a15451910526cea3ea50c21f
Author:     Daniel O'Connor <darius@dons.net.au>
AuthorDate: 2022-08-16 15:47:41 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-08-16 15:54:44 +0000

    sysutils/pefs-kmod: Update to work on FreeBSD 13.1-RC1

    This updates to a version with fixes for various KABI changes in FreeBSD 13+.

    PR:     263058
    Reported by:     darius@dons.net.au (maintainer)

 sysutils/pefs-kmod/Makefile | 15 ++++++++-------
 sysutils/pefs-kmod/distinfo |  6 +++---
 2 files changed, 11 insertions(+), 10 deletions(-)
Comment 8 Daniel O'Connor 2022-08-16 23:25:14 UTC
Thanks Fernando :)
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-09-24 11:56:25 UTC
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b4cc66ed4893b08a82198e41928d4ea51876e1a8

commit b4cc66ed4893b08a82198e41928d4ea51876e1a8
Author:     Daniel O'Connor <darius@dons.net.au>
AuthorDate: 2022-08-16 15:47:41 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2022-09-24 11:53:45 +0000

    sysutils/pefs-kmod: Update to work on FreeBSD 13.1-RC1

    This updates to a version with fixes for various KABI changes in FreeBSD 13+.

    PR:     263058
    Reported by:     darius@dons.net.au (maintainer)

    (cherry picked from commit 79f9679c7e795de9a15451910526cea3ea50c21f)

    PR:     266576

 sysutils/pefs-kmod/Makefile | 13 ++++++-------
 sysutils/pefs-kmod/distinfo |  6 +++---
 2 files changed, 9 insertions(+), 10 deletions(-)