Bug 263115 - net-mgmt/icingaweb2: Update to 2.10.1
Summary: net-mgmt/icingaweb2: Update to 2.10.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-07 09:59 UTC by linus.sundqvist
Modified: 2023-01-23 17:59 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (joneum)


Attachments
net-mgmt-icinga-ipl-i18n-Fix-install-path (1.13 KB, patch)
2023-01-18 21:44 UTC, Florian Smeets
flo: maintainer-approval? (joneum)
Details | Diff
net-mgmt-icinga-php-library-Fix-install-path-and-dependencies (1.50 KB, patch)
2023-01-18 21:44 UTC, Florian Smeets
flo: maintainer-approval? (joneum)
Details | Diff
net-mgmt-icinga-php-thirdparty-Fix-install-path-and-dependencies (1.97 KB, patch)
2023-01-18 21:45 UTC, Florian Smeets
flo: maintainer-approval? (joneum)
Details | Diff
Update to 1.10.2 (39.74 KB, patch)
2023-01-18 21:46 UTC, Florian Smeets
flo: maintainer-approval? (joneum)
Details | Diff
Update to 0.10.0 (8.34 KB, patch)
2023-01-18 21:46 UTC, Florian Smeets
flo: maintainer-approval? (joneum)
Details | Diff
Update to 2.11.3 (123.97 KB, patch)
2023-01-18 21:47 UTC, Florian Smeets
flo: maintainer-approval? (joneum)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description linus.sundqvist 2022-04-07 09:59:20 UTC
This port has not received love in a little while. Upstream released version 2.10.1 yesterday (current version in ports is 2.8.2, 19 Aug 2020), but since version 2.9 Icinga has changed some dependencies.
Versions abose 2.9 also adds support for PHP8+.

For example the port net-mgmt/icingaweb2-module-ipl has been deprecated upstream by https://github.com/Icinga/ipl-i18n, which is required to build latest icingaweb2.

ipl-i18n also seems to be included with https://github.com/Icinga/icinga-php-library so maybe this should be a new port and added as a dependency for icingaweb2.

I'm unfortunately not savvy enough to update icingaweb2 and add a new port for icinga-php-library so I hope the maintainer is able to :)
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-04-10 18:22:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3763ef633f86c5201a3a340687070973119a4472

commit 3763ef633f86c5201a3a340687070973119a4472
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2022-04-10 17:57:16 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2022-04-10 18:21:13 +0000

    www/py-grip: Update to 4.6.1

    This version adds support for Flask (www/py-flask) >= 2.1.0. Previous
    versions of grip will crash due to the missing safe_join function which
    was removed from Flask in version 2.1.0. Fixes [1].

    PR:             263115 [1]
    Reported by:    jwb [1]
    MFH:            2022Q2

 www/py-grip/Makefile | 5 +++--
 www/py-grip/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-04-10 18:34:42 UTC
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b1662c56db127e506a5973667bb79fb0314a5d30

commit b1662c56db127e506a5973667bb79fb0314a5d30
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2022-04-10 17:57:16 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2022-04-10 18:33:01 +0000

    www/py-grip: Update to 4.6.1

    This version adds support for Flask (www/py-flask) >= 2.1.0. Previous
    versions of grip will crash due to the missing safe_join function which
    was removed from Flask in version 2.1.0. Fixes [1].

    PR:             263115 [1]
    Reported by:    jwb [1]
    MFH:            2022Q2

    (cherry picked from commit 3763ef633f86c5201a3a340687070973119a4472)

 www/py-grip/Makefile | 5 +++--
 www/py-grip/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2022-04-10 18:42:48 UTC
(In reply to commit-hook from comment #1)

Sorry about these commit messages, they were meant for bug #263155. I fat-fingered the PR number.
Comment 4 Jonas Palm 2022-11-03 13:13:49 UTC
Update to the current version 2.11.1 would be very much appreciated.

The current version of the port only works with php74 which will be EOL at the end of the month and will probably be removed in the foreseeable future.
Comment 5 Jochen Neumeister freebsd_committer freebsd_triage 2022-12-28 09:50:34 UTC
(In reply to Jonas Palm from comment #4)

youre patch is welcome :-)
Comment 6 Florian Smeets freebsd_committer freebsd_triage 2023-01-18 21:44:07 UTC
Created attachment 239565 [details]
net-mgmt-icinga-ipl-i18n-Fix-install-path
Comment 7 Florian Smeets freebsd_committer freebsd_triage 2023-01-18 21:44:52 UTC
Created attachment 239566 [details]
net-mgmt-icinga-php-library-Fix-install-path-and-dependencies
Comment 8 Florian Smeets freebsd_committer freebsd_triage 2023-01-18 21:45:38 UTC
Created attachment 239567 [details]
net-mgmt-icinga-php-thirdparty-Fix-install-path-and-dependencies
Comment 9 Florian Smeets freebsd_committer freebsd_triage 2023-01-18 21:46:10 UTC
Created attachment 239568 [details]
Update to 1.10.2
Comment 10 Florian Smeets freebsd_committer freebsd_triage 2023-01-18 21:46:39 UTC
Created attachment 239569 [details]
Update to 0.10.0
Comment 11 Florian Smeets freebsd_committer freebsd_triage 2023-01-18 21:47:11 UTC
Created attachment 239570 [details]
Update to 2.11.3
Comment 12 Florian Smeets freebsd_committer freebsd_triage 2023-01-18 22:00:07 UTC
Here are the requested patches. Please approve. As not much happened to the icingaweb2* ports over the last 18 months I'm happy to take over maintainership.

The missing patches 0005 and 0007 in the attached series are PRs 269036 and 269037 maintained by someone else.

If someone want's to give this a shot, the complete patch can be downloaded here: https://tb.smeets.xyz/~flo/icingaweb2%2Bmodules-update.diff 

That's what I used to update our production icinga2/icingaweb2 instance.

Florian
Comment 13 Jochen Neumeister freebsd_committer freebsd_triage 2023-01-20 07:39:34 UTC
Hello Flo,

thanks for the update and the patches. There was a parallel update to this under D38018 in the reviews. 
As soon as your 2 other PRs to icingaweb2 are committed, I will commit icingaweb2.
Comment 14 commit-hook freebsd_committer freebsd_triage 2023-01-23 14:09:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8295feba03e13477dfbf426f51af3d73d01df152

commit 8295feba03e13477dfbf426f51af3d73d01df152
Author:     Jochen Neumeister <joneum@FreeBSD.org>
AuthorDate: 2023-01-23 14:02:52 +0000
Commit:     Jochen Neumeister <joneum@FreeBSD.org>
CommitDate: 2023-01-23 14:02:52 +0000

    net-mgmt/icingaweb2: Update to 2.11.3

    Changelog: https://github.com/Icinga/icingaweb2/blob/master/CHANGELOG.md

    PR:     263115
    Patch from:     flo
    Differential Revision:  https://reviews.freebsd.org/D38018
    Sponsored by:   Netzkommune GmbH

 net-mgmt/icinga-ipl-i18n/Makefile                  |    3 +-
 net-mgmt/icinga-php-library/Makefile               |    5 +-
 net-mgmt/icinga-php-thirdparty/Makefile            |    4 +-
 net-mgmt/icinga-php-thirdparty/pkg-descr           |    4 +-
 net-mgmt/icingaweb2/Makefile                       |   24 +-
 net-mgmt/icingaweb2/distinfo                       |    6 +-
 .../icingaweb2/files/patch-4bc5350ebaae (gone)     | 1054 --------------------
 .../icingaweb2/files/patch-dc7a8c8d8b6e (gone)     |  193 ----
 net-mgmt/icingaweb2/files/pkg-message.in           |   14 +-
 net-mgmt/icingaweb2/pkg-plist                      |  719 ++++++++-----
 10 files changed, 483 insertions(+), 1543 deletions(-)
Comment 15 Florian Smeets freebsd_committer freebsd_triage 2023-01-23 17:36:10 UTC
Hi Jochen,

thanks for committing the icingaweb2 update. This PR also included patches for icingaweb2-module-director and icingaweb2-module-reporting. The naming of the patches made it quite non-obvious, sorry.

Update to 1.10.2 is icingaweb2-module-director
Update to 0.10.0 is icingaweb2-module-reporting

Thanks
Florian
Comment 16 Jochen Neumeister freebsd_committer freebsd_triage 2023-01-23 17:59:50 UTC
I am in the process of updating all other icinga ports, this process has been running in the background for several hours.
but thanks for the hint