Hi, it seems that when building wifimgr without the NLS option on results in make errors: ===> Building for wifimgr-1.19 --- do-build --- --- do-build --- --- do-build --- --- do-build --- --- do-build --- cd icons; /usr/bin/make --- do-build --- cd po; /usr/bin/make --- do-build --- cd man; /usr/bin/make --- do-build --- cd src; /usr/bin/make --- do-build --- make[2]: make[2]: don't know how to make do-build. Stop make[2]: stopped in /wrkdirs/usr/ports/net-mgmt/wifimgr/work/wifimgr-1.19/po *** [do-build] Error code 2 make[1]: stopped in /wrkdirs/usr/ports/net-mgmt/wifimgr/work/wifimgr-1.19 --- do-build --- --- wifimgr.desktop --- --- do-build --- --- wifimgr.8.gz --- --- do-build --- sed 's,%%PREFIX%%,/usr/local,' wifimgr.desktop.in >wifimgr.desktop --- do-build --- gzip -c wifimgr.8 >wifimgr.8.gz --- do-build --- *** [do-build] Error code 6 make[1]: stopped in /wrkdirs/usr/ports/net-mgmt/wifimgr/work/wifimgr-1.19 --- do-build --- *** [do-build] Error code 6 make[1]: stopped in /wrkdirs/usr/ports/net-mgmt/wifimgr/work/wifimgr-1.19 --- do-build --- *** [do-build] Error code 6 make[1]: stopped in /wrkdirs/usr/ports/net-mgmt/wifimgr/work/wifimgr-1.19 4 errors make[1]: stopped in /wrkdirs/usr/ports/net-mgmt/wifimgr/work/wifimgr-1.19 ===> Compilation failed unexpectedly. Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to the maintainer. *** Error code 1
I just ran: OPTIONS_UNSET=NLS make and it built and staged okay.
Ah, I see that the saved config here overrode the OPTIONS_UNSET envar so my successful build just now wasn't actually with NLS unset. Okay, this patch should fix it. If okay, I will get a port update out tomorrow. diff --git a/po/Makefile b/po/Makefile index ab1d151..20f0b51 100644 --- a/po/Makefile +++ b/po/Makefile @@ -53,4 +53,14 @@ pot: wifimgr.pot wifimgr.pot: ../src/wifimgr.pot if [ -f $@ ]; then ${MSGMERGE} -U $@ $?; else ${CP} $? $@; fi +.else + +do-build: + +do-clean: + +do-install: + +do-deinstall: + .endif
Created attachment 233247 [details] patch to update port from 1.19 to 1.20 Patch updates port to wifimgr-1.20. No changes to actual wifimgr code between 1.19 and 1.20. Only changes are: - po/Makefile fixes to re-enable build with WITHOUT_NLS - wifimgr.desktop.in remove unused MimeTypes variabe
Great! Thanks
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=81521a91ed6f4cb783f15b60bca5846af5f657c9 commit 81521a91ed6f4cb783f15b60bca5846af5f657c9 Author: J.R. Oldroyd <fbsd@opal.com> AuthorDate: 2022-04-20 11:59:34 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2022-04-20 13:48:01 +0000 net-mgmt/wifimgr: Update to 1.20 No changes to actual wifimgr code between 1.19 and 1.20. Only changes are: - po/Makefile fixes to re-enable build with WITHOUT_NLS - wifimgr.desktop.in remove unused MimeTypes variabe PR: 263150 net-mgmt/wifimgr/Makefile | 2 +- net-mgmt/wifimgr/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
Thanks!