Bug 263275 - textproc/gnugrep: man page depends on groff - add as a dependency.
Summary: textproc/gnugrep: man page depends on groff - add as a dependency.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-14 10:50 UTC by Duane
Modified: 2022-08-11 10:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Duane 2022-04-14 10:50:06 UTC

    
Comment 1 Duane 2022-04-14 10:52:26 UTC
Sorry, the bug submission triggered before I was ready...

gnugrep was pulled in as a dependency and I was surprised to discover that I could no longer access the man page for it since it needs groff to render the page.

I was also surprised that gnugrep is no longer installed as ggrep... don't know when that change happened but I liked it better when all the gnu utilities had a 'g' prefix.
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2022-04-15 13:37:49 UTC
(In reply to Duane from comment #1)
Indeed, you're right:

> $ man /usr/local/man/man1/grep.1.gz
> This manpage needs groff(1) to be rendered
> First install groff(1):
> pkg install groff
Dependency on groff(1) should be added.

> I was also surprised that gnugrep is no longer installed as ggrep.
While some other GNU ports, e.g. textproc/gsed, are built with --program-prefix=g, GNU grep had been traditionally configured without it, at least since 2010.  Can you remember when it was installed as ggrgep(1)?  Not to say that it's a bad idea, it actually makes sense, we might want to switch to it for consistency with other GNU tools.
Comment 3 Duane 2022-04-15 14:34:35 UTC
(In reply to Alexey Dokuchaev from comment #2)

Maybe FreeBSD didn’t have ggrep. I’ve used a few other non-Linux systems over the years so I might be misremembering. I know Solaris definitely did have it. Some online research suggests that OpenBSD, NetBSD (via pkgsrc), and Mac OS X (through brew) also do it that way (although often also making it available under something like /usr/local/gnu/bin/grep which is really nice because it keeps all the GNU stuff together and you can still choose to path it in if you want it or need it for some script).
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-08-11 10:15:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f515b0e657e7bd11d88725e9bc3cb1ccb3706baa

commit f515b0e657e7bd11d88725e9bc3cb1ccb3706baa
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2022-08-11 10:13:08 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2022-08-11 10:13:08 +0000

    textproc/gnugrep: add missing dependency, build with --program-prefix=g

    - Add run-time dependency on `textproc/groff': the manual page won't be
      rendered if groff(1) is not installed;
    - By popular demand, configure the port with `--program-prefix=g' as we
      do for other GNU utilities.  This places the binaries within the same
      namespace more consistently; several other non-GNU/Linux systems, e.g.
      NetBSD, OpenBSD, Solaris, macOS (Homebrew) are doing the same.  Avoid
      POLA violation by creating traditionally named compatibility symlinks.

    PR:     263275, 265729

 textproc/gnugrep/Makefile  | 9 +++++++++
 textproc/gnugrep/pkg-plist | 9 ++++++---
 2 files changed, 15 insertions(+), 3 deletions(-)