Created attachment 233261 [details] Patch to add libgig to ${LIB_DEPENDS} lmms is failing to built when the port can not find GIG player: [...] -- Looking for include file process.h - not found -- Looking for include file locale.h -- Looking for include file locale.h - found -- Found Qt translations in /usr/local/share/qt5/translations -- Checking for module 'sndfile>=1.0.11' -- Found sndfile, version 1.0.31 -- Checking for module 'carla-native-plugin' -- Found carla-native-plugin, version 2.4.2 -- Looking for pthread.h -- Looking for pthread.h - found -- Found Threads: TRUE -- Could NOT find SDL (missing: SDL_LIBRARY) CMake Warning (dev) at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438 (message): The package name passed to `find_package_handle_standard_args` (SOUNDIO) does not match the name of the calling package (SoundIo). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): cmake/modules/FindSoundIo.cmake:14 (find_package_handle_standard_args) CMakeLists.txt:310 (FIND_PACKAGE) This warning is for project developers. Use -Wno-dev to suppress it. -- Could NOT find SOUNDIO (missing: SOUNDIO_LIBRARY SOUNDIO_INCLUDE_DIR) -- Could NOT find Lame (missing: LAME_INCLUDE_DIRS LAME_LIBRARIES) -- Looking for vorbis_bitrate_addblock in vorbis -- Looking for vorbis_bitrate_addblock in vorbis - not found -- Found OggVorbis: /usr/local/lib/libogg.so;/usr/local/lib/libvorbis.so;/usr/local/lib/libvorbisfile.so;/usr/local/lib/libvorbisenc.so -- Checking for module 'jack>=0.77' -- Found jack, version 1.9.20 -- Checking for module 'fftw3f>=3.0.0' -- Found fftw3f, version 3.3.10 CMake Warning (dev) at /usr/local/share/cmake/Modules/FindOpenGL.cmake:315 (message): Policy CMP0072 is not set: FindOpenGL prefers GLVND by default when available. Run "cmake --help-policy CMP0072" for policy details. Use the cmake_policy command to set the policy and suppress this warning. FindOpenGL found both a legacy GL library: OPENGL_gl_LIBRARY: /usr/local/lib/libGL.so and GLVND libraries for OpenGL and GLX: OPENGL_opengl_LIBRARY: /usr/local/lib/libOpenGL.so OPENGL_glx_LIBRARY: /usr/local/lib/libGLX.so OpenGL_GL_PREFERENCE has not been set to "GLVND" or "LEGACY", so for compatibility with CMake 3.10 and below the legacy GL library will be used. Call Stack (most recent call first): /usr/local/share/cmake/Modules/FindFLTK.cmake:87 (find_package) CMakeLists.txt:419 (FIND_PACKAGE) This warning is for project developers. Use -Wno-dev to suppress it. -- Found OpenGL: /usr/local/lib/libOpenGL.so -- Found X11: /usr/local/include -- Looking for XOpenDisplay in /usr/local/lib/libX11.so;/usr/local/lib/libXext.so -- Looking for XOpenDisplay in /usr/local/lib/libX11.so;/usr/local/lib/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found FLTK: /usr/local/lib/libfltk_images.so;/usr/local/lib/libfltk_forms.so;/usr/local/lib/libfltk_gl.so;/usr/local/lib/libGL.so;/usr/local/lib/libfltk.so -- Checking for module 'fluidsynth>=1.0.7' -- Found fluidsynth, version 2.2.6 -- Checking for module 'gig' -- Package 'gig', required by 'virtual:world', not found -- Checking for module 'samplerate>=0.1.8' -- Found samplerate, version 0.2.2 -- Could NOT find Git (missing: GIT_EXECUTABLE) CMake Deprecation Warning at plugins/carlabase/CMakeLists.txt:6 (CMAKE_POLICY): The OLD behavior for policy CMP0068 will be removed from a future version of CMake. The cmake-policies(7) manual explains that the OLD behaviors of all policies are deprecated and that a policy should be set to OLD only under specific short-term circumstances. Projects should be ported to the NEW behavior and not rely on setting a policy to OLD. -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) Installation Summary -------------------- * Install Directory : /usr/local Supported audio interfaces -------------------------- * ALSA : * JACK : OK (weak linking enabled) * OSS : OK * Sndio : * PortAudio : * libsoundio : not found, please install libsoundio if you require libsoundio support * PulseAudio : * SDL : not found, please install libsdl1.2-dev (or similar) ;if you require SDL support Supported MIDI interfaces ------------------------- * ALSA : * OSS : OK * Sndio : * JACK : OK (weak linking enabled) * WinMM : <not supported on this platform> * AppleMidi : <not supported on this platform> Supported file formats for project export ----------------------------------------- * WAVE : OK * OGG/VORBIS : OK * MP3/Lame : not found, please install libmp3lame-dev (or similar) Optional plugins ---------------- * Carla Patchbay & Rack : OK * SoundFont2 player : OK * Stk Mallets : * VST-instrument hoster : * VST-effect hoster : * CALF LADSPA plugins : not built as requested * CAPS LADSPA plugins : not built as requested * CMT LADSPA plugins : not built as requested * TAP LADSPA plugins : not built as requested * SWH LADSPA plugins : not built as requested * GIG player : not found, libgig needed for decoding .gig files [...] =========================================================================== =======================<phase: package >============================ ===== env: 'PKG_NOTES=build_timestamp built_by' 'PKG_NOTE_build_timestamp=2022-04-16T02:41:10+0000' 'PKG_NOTE_built_by=poudriere-git-3.3.99.20211130' NO_DEPENDS=yes USER=root UID=0 GID=0 ===> Building package for lmms-1.2.2_3,2 pkg-static: Unable to access file /wrkdirs/usr/ports/audio/lmms/work/stage/usr/local/lib/lmms/libgigplayer.so:No such file or directory *** Error code 1 Stop. make: stopped in /usr/ports/audio/lmms =>> Cleaning up wrkdir ===> Cleaning for lmms-1.2.2_3,2 build of audio/lmms | lmms-1.2.2_3,2 ended at Sat Apr 16 02:48:08 UTC 2022 build time: 00:06:58 !!! build failure encountered !!!
Hi Alastair, Thanks for your report. Can you provide more details about your environment ? - FreeBSD version and arch - do you set/unset default options - full build log as an attachment I'm not able to reproduce your issue. BTW, since libcarla update, the patch attached to PR263502[1] is required to build lmms. Cheers, -- rodrigo [1]https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263502
(In reply to Rodrigo Osorio from comment #1) Hi Rodrigo, > - FreeBSD version and arch $ uname -a FreeBSD direwolf.home.arpa. 14.0-CURRENT FreeBSD 14.0-CURRENT #0 main-n255024-835ee05f3c7: Sun Apr 24 11:26:26 AWST 2022 agh@direwolf.home.arpa.:/tmp/direwolf/usr/src/amd64.amd64/sys/DIREWOLF amd64 > - do you set/unset default options [trim build log] ---Begin OPTIONS List--- ===> The following configuration options are available for lmms-1.2.2_4,2: JACK=on: JACK audio server support OSS=on: Open Sound System support PORTAUDIO=off: PortAudio library support PULSEAUDIO=off: PulseAudio sound server support SDL=off: Simple Direct Media Layer support SNDIO=off: Sndio audio support > - full build log as an attachment It is 2.5MiB. Will try and find somewhere for it.
(In reply to Alastair Hogge from comment #2) Alastair, Thanks for the details. For the full log, you can simply attach it to the PR, and if you care about space just compress it before. We prefer to have logs attached to the PR instead of external links because sometime host on the internet disappear and we loose the PR history. regards, -- rodrigo
Created attachment 233476 [details] Build log
Can reproduce when audio/carla is built without option LINUXSAMPLER.
(In reply to Alastair Hogge from comment #5) Ok, that's explains why this error never occurs with default build. May I ask you why you disable the LINUXSAMPLER libcarla capability ?
(In reply to Rodrigo Osorio from comment #6) > May I ask you why you disable the LINUXSAMPLER libcarla capability ? I have no idea, perhaps some tuning or bug hunting many years ago.
Linuxsampler is marked as broken when configured with ALSA support. Compilation stops without mentioning that it would compile without ALSA: ===> linuxsampler-2.2.0_2 is marked as broken: error: unknown type name 'snd_pcm_t'. *** Error code 1 The logical consequence is to configure Carla without Linuxsampler. Then you run into the missing-file error in lmms and don't know why. This definitely doesn't "work as intended".
(In reply to Friedrich Volkmann from comment #8) >The logical consequence is to configure Carla without Linuxsampler. Then you run into the missing-file error in lmms and don't know why. > This definitely doesn't "work as intended". I have reopened the bug report, however, should there a separate bug report for this issue and Carla instead?
(In reply to Alastair Hogge from comment #9) I'm not a port hacker. From what I can see as a user, there's nothing wrong with Carla. The missing-file error comes in lmms. If the lmms port requires a certain file, it should define all the necessary checks and (direct) dependencies to make sure it is there. If the file is not strictly necessary, i.e. if the port could install without the missing file, its inclusion in the pkg-plist should not be fixed but dependent on whether it is built. A separate bug report for linuxsampler might be adequate though. Given that ALSA support breaks it, it should be disabled as a config option.
(In reply to Friedrich Volkmann from comment #10) > I'm not a port hacker. From what I can see as a user, there's nothing wrong with Carla. The missing-file error comes in lmms. If the lmms port requires a certain file, it should define all the necessary checks and (direct) dependencies to make sure it is there. If the file is not strictly necessary, i.e. if the port could install without the missing file, its inclusion in the pkg-plist should not be fixed but dependent on whether it is built. I agree.
Hi, I think I have a fix for that issue. If it works properly, it can be commit in the upcoming days Cheers, -- rodrigo
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=11b1ba4c7ae5ba77ace0a8dacb5140ecaa60bceb commit 11b1ba4c7ae5ba77ace0a8dacb5140ecaa60bceb Author: Rodrigo Osorio <rodrigo@FreeBSD.org> AuthorDate: 2023-11-02 10:28:50 +0000 Commit: Rodrigo Osorio <rodrigo@FreeBSD.org> CommitDate: 2023-11-02 10:34:29 +0000 audio/lmms: Fix plist Remove missing libgigplayer.so file from plist Add missing dependecy to audio/lame reported by testport Do some cleanup to make linters happy. PR: 263355 Reported by: Alastair Hogge <agh@riseup.net> audio/lmms/Makefile | 38 +++++++++++++++++--------------------- audio/lmms/pkg-plist | 1 - 2 files changed, 17 insertions(+), 22 deletions(-)
Committed, thanks for your patience and understanding
(In reply to Rodrigo Osorio from comment #14) You are a legend 🦿 Thanks very much.
A commit in branch 2023Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6dfdfcacf42d2127429c3cd0c08ead428685dedd commit 6dfdfcacf42d2127429c3cd0c08ead428685dedd Author: Rodrigo Osorio <rodrigo@FreeBSD.org> AuthorDate: 2023-11-02 10:28:50 +0000 Commit: Rodrigo Osorio <rodrigo@FreeBSD.org> CommitDate: 2023-12-08 07:34:35 +0000 audio/lmms: Fix plist Remove missing libgigplayer.so file from plist Add missing dependecy to audio/lame reported by testport Do some cleanup to make linters happy. PR: 263355 Reported by: Alastair Hogge <agh@riseup.net> (cherry picked from commit 11b1ba4c7ae5ba77ace0a8dacb5140ecaa60bceb) audio/lmms/Makefile | 38 +++++++++++++++++--------------------- audio/lmms/pkg-plist | 1 - 2 files changed, 17 insertions(+), 22 deletions(-)