Bug 263432 - deskutils/calibre: Add missing dependency on py-feedparser
Summary: deskutils/calibre: Add missing dependency on py-feedparser
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-20 05:26 UTC by Kevin Zheng
Modified: 2022-04-20 20:14 UTC (History)
0 users

See Also:
madpilot: maintainer-feedback+
madpilot: merge-quarterly+

Attachments
Patch (1.22 KB, patch)
2022-04-20 05:26 UTC, Kevin Zheng 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2022-04-20 05:26:50 UTC 
Created attachment 233352 [details]
Patch

py-feedparser is needed by calibre in order for the Fetch News
functionality to work.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2022-04-20 07:52:50 UTC 
Hi,

Thanks for reporting the issue. I'll look into this shortly.

For the record, I'm not using the calibre news functionality, this explains why I did not notice the missing dependency.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-04-20 19:28:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bfc77a3362ce74b8c04e03dd048b6903f0bab62e

commit bfc77a3362ce74b8c04e03dd048b6903f0bab62e
Author:     Kevin Zheng <kevinz5000@gmail.com>
AuthorDate: 2022-04-20 19:26:02 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2022-04-20 19:28:05 +0000

    deskutils/calibre: Add missing dependency

    Add py-feedparser, which is needed for the news feed functionality
    in claibre.

    PR:             263432
    MFH:            2022Q2

 deskutils/calibre/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-04-20 19:31:50 UTC 
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1bcad339aed703a43c90f7e95f20f55bc3a07b65

commit 1bcad339aed703a43c90f7e95f20f55bc3a07b65
Author:     Kevin Zheng <kevinz5000@gmail.com>
AuthorDate: 2022-04-20 19:26:02 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2022-04-20 19:30:45 +0000

    deskutils/calibre: Add missing dependency

    Add py-feedparser, which is needed for the news feed functionality
    in claibre.

    PR:             263432
    MFH:            2022Q2
    (cherry picked from commit bfc77a3362ce74b8c04e03dd048b6903f0bab62e)

 deskutils/calibre/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2022-04-20 19:35:18 UTC 
Committed and merged to quarterly.

Thanks again for reporting.

BTW your patch contained an error in the RUN_DEPENDS syntax, you can view at the correct syntax in the commit, and surrounding lines.
Comment 5 Kevin Zheng 2022-04-20 20:14:52 UTC 
(In reply to Guido Falsi from comment #4)
Thanks Guido, for the review and corrected patch.