Bug 263456 - [exp-run] update LLVM_DEFAULT to 15
Summary: [exp-run] update LLVM_DEFAULT to 15
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks: 263302
  Show dependency tree / graph
 
Reported: 2022-04-21 16:22 UTC by Tobias C. Berner
Modified: 2023-01-03 09:24 UTC (History)
8 users (show)

See Also:
antoine: exp-run+

Attachments
v1 (995 bytes, patch)
2022-04-21 16:22 UTC, Tobias C. Berner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias C. Berner freebsd_committer freebsd_triage 2022-04-21 16:22:45 UTC 
Created attachment 233380 [details]
v1

Moin moin 

I would like to ask for an exp-run to set LLVM_DEFAULT to something modern like 13.

The patch is attached, and can also be found here:
https://people.freebsd.org/~tcberner/patches/0001-Mk-bsd.default-versions.mk-Bump-LLVM_DEFAULT-to-13.patch



mfg Tobias
Comment 1 Emmanuel Vadot freebsd_committer freebsd_triage 2022-04-21 18:11:59 UTC 
ok for x11@ to remove the comment.
The only part we are interested about is mesa and we override LLVM_DEFAULT there.
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2022-05-20 16:39:19 UTC 
(In reply to Antoine Brodin from comment #4)
Thanks, I will take a look at the fallout.
Comment 6 Adriaan de Groot freebsd_committer freebsd_triage 2022-08-16 11:19:36 UTC 
- tvm: has updated since this exp-run, now seems to work
- youcompleteme: has updated since this exp-run, now seems to work

- halide: outdated port, I've filed a bug for yuri@
- castxml: bad OPTIONS section, I've filed a bug for yuri@
- py-llvmlite: the LLVM dependency is just wrong, it must be 10, I've filed a bug for the maintainer

For android-tools-simpleperf and clazy, both are building as C++11, but LLVM13 headers require a later C++ standard (in particular, the headers use std::enable_if_t, which is C++14). *Probably* those can be fixed by bumping the C++ standard on them.
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-08-16 11:57:00 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37f10e75dd32a4638beb26954081e2622af25142

commit 37f10e75dd32a4638beb26954081e2622af25142
Author:     Adriaan de Groot <adridg@FreeBSD.org>
AuthorDate: 2022-08-16 11:49:46 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2022-08-16 11:56:48 +0000

    devel/clazy: update to 1.11, latest upstream

    We missed a few years (!) of clazy updates. Jump to current. The
    changelog is at
            https://invent.kde.org/sdk/clazy/-/blob/master/Changelog
    and describes many new and improved checks.

    This also removes a blocker for bumping LLVM_DEFAULT (linked PR).

    PR:             263456

 devel/clazy/Makefile                          |  7 +++---
 devel/clazy/distinfo                          |  6 ++---
 devel/clazy/files/patch-CMakeLists.txt (gone) | 11 ---------
 devel/clazy/pkg-plist                         | 35 +++++++++++++++++++--------
 4 files changed, 32 insertions(+), 27 deletions(-)
Comment 8 Piotr Kubaj freebsd_committer freebsd_triage 2022-09-01 10:05:19 UTC 
For the ports that don't support adding compilation flags by setting CFLAGS, there may be other ways, like a proper configure or make switch. I'm not sure about jam, but boost-jam had a similar issue of not respecting CXXFLAGS, which broke runtime on e5500 (powerpc64), fixed in https://cgit.freebsd.org/ports/commit/?id=732b245ce11d3cef4c33c87c91ff8d28e336091f.
Comment 9 Piotr Kubaj freebsd_committer freebsd_triage 2022-09-01 10:05:46 UTC 
Sorry, not this PR.
Comment 10 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-05 19:32:11 UTC 
With mesa now having switched to llvm15 in 855947ebf7e738232a8bbf6d47cc56f2896f276f it would be prudent to try and push LLVM_DEFAULT to 15 by default.

@antoine

Could you rerun it for llvm15
https://people.freebsd.org/~tcberner/patches/0001-bsd.default-versions.mk-update-llvm_default-to-15.patch

mfg Tobias
Comment 14 Michael Osipov 2022-12-13 20:49:41 UTC 
The issue summary says 15, not 13.
Comment 15 Michael Osipov 2022-12-13 20:50:04 UTC 
(In reply to Michael Osipov from comment #14)

Forget it, my bad.
Comment 17 Gleb Popov freebsd_committer freebsd_triage 2022-12-14 16:52:41 UTC 
KLEE only supports llvm13 as of now.
Comment 18 Emmanuel Vadot freebsd_committer freebsd_triage 2022-12-15 07:39:50 UTC 
(In reply to Gleb Popov from comment #17)

Then it shouldn't use LLVM_DEFAULT but a pinned version. (note that it should use llvm90 right now as it's still the default so do you mean it only supports <= llvm13 ?)
Comment 19 commit-hook freebsd_committer freebsd_triage 2022-12-17 17:19:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8c772d8e053eaca59a6095013d31e30959d13b38

commit 8c772d8e053eaca59a6095013d31e30959d13b38
Author:     Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2022-12-17 17:18:10 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2022-12-17 17:18:31 +0000

    security/klee: Switch to LLVM 13.

    PR:             263456

 security/klee/Makefile | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
Comment 20 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-17 23:05:31 UTC 
(In reply to Antoine Brodin from comment #16)
Moin moin


I cannot reproduce the crashes found in the logs for emulators/rpcs3@qt5 and emulators/rpcs3@qt6 . Those build fine here.
Comment 21 commit-hook freebsd_committer freebsd_triage 2022-12-17 23:13:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e66cf64fcf9beea7e3937491d113bbbee50bf263

commit e66cf64fcf9beea7e3937491d113bbbee50bf263
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-12-17 20:45:01 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-12-17 23:10:16 +0000

    devel/ccls: lock llvm-version at 9

    LLVM_DEFAULT will be bumped to 15, this port fails with:
            [...]
            /wrkdirs/usr/ports/devel/ccls/work/ccls-0.20210330/src/indexer.cc:530:21: error: use of undeclared identifier 'isIdentifierBody'; did you mean 'IdentifierLoc'?
                         ((i && isIdentifierBody(name[i - 1])) ||
                                ^
            [...]

    PR:             263456

 devel/ccls/Makefile | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
Comment 22 commit-hook freebsd_committer freebsd_triage 2022-12-17 23:13:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f815d3802109d816bef09333a201e0b88dfcd0d2

commit f815d3802109d816bef09333a201e0b88dfcd0d2
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-12-17 20:59:51 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-12-17 23:10:23 +0000

    devel/gnome-builder: prepare for LLVM_DEFAULT=15

    Previous failure:
            [...]
            llvm-config found: NO need ['>= 3.5']
            Run-time dependency LLVM found: NO (tried config-tool)
            [...]

    PR:             263456

 devel/gnome-builder/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Comment 23 commit-hook freebsd_committer freebsd_triage 2022-12-17 23:13:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d2a712f7c12ae14b03c48b4098a7d84d6b0744ca

commit d2a712f7c12ae14b03c48b4098a7d84d6b0744ca
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-12-17 20:28:23 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-12-17 23:10:10 +0000

    devel/android-tools-simpleperf: lock llvm-version at 9

    LLVM_DEFAULT will be bumped to 15, this port fails with:
            [...]
            /usr/local/llvm15/include/llvm/ADT/STLForwardCompat.h:74:21:
            error: no template named 'remove_cv_t' i n namespace 'std'; did
            you mean 'remove_cv'?
              using type = std::remove_cv_t<std::remove_reference_t<T>>;
                           ~~~~~^~~~~~~~~~~
                                remove_cv
            [...]

    PR:             263456

 devel/android-tools-simpleperf/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Comment 24 commit-hook freebsd_committer freebsd_triage 2022-12-17 23:13:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c49f3491b8e2ca2bbe2fd32f6ccfb0818a0ab9d6

commit c49f3491b8e2ca2bbe2fd32f6ccfb0818a0ab9d6
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-12-17 21:16:33 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-12-17 23:10:33 +0000

    databases/xtrabackup: fix llvm version at 10 explicitely

    In the previous commit [1] in 2021, clang was locked at 10:
        Compilation of the embedded mysql server fail with clang 11, use clang 10 as
        workaround (same as databases/mysql57-server do).

    As LLVM_DEFAULT will now be higher than 10, explicitely depend on 10.

    Note:
            USES=llvm:max=10
    would be the preferable solution for this usecase, however, llvm.mk
    cannot be used after bsd.options.mk at the moment.

    [1] 106d01226d33ce7f76ca480bb9d9598a3b711b60

    PR:             263456

 databases/xtrabackup/Makefile | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 25 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-17 23:14:51 UTC 
(In reply to commit-hook from comment #24)
@antoine

Could you re-run it -- all issues should be addressed or are not reproducible here.

mfg Tobias
Comment 26 commit-hook freebsd_committer freebsd_triage 2022-12-17 23:22:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=be52987d67ee9f248be21a4f9579fb00d63a9b6c

commit be52987d67ee9f248be21a4f9579fb00d63a9b6c
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-12-17 23:20:54 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-12-17 23:20:54 +0000

    devel/gnome-builder: lock at llvm 9

    In f815d3802109d816bef09333a201e0b88dfcd0d2 the build was changed
    to theoretically support higher llvm-versions, however, the build
    was still linking to llvm9. So make this explicit.

    PR:             263456

 devel/gnome-builder/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 27 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-30 09:08:25 UTC 
(In reply to Tobias C. Berner from comment #25)
@antoine -- is there any new falloutin the meantime?
Comment 28 Antoine Brodin freebsd_committer freebsd_triage 2023-01-03 08:12:17 UTC 
This seems fine
Comment 29 commit-hook freebsd_committer freebsd_triage 2023-01-03 09:24:09 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9742a6346057545688a02ae3eb537ac39c6b296c

commit 9742a6346057545688a02ae3eb537ac39c6b296c
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2023-01-03 09:19:27 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2023-01-03 09:22:21 +0000

    Mk/bsd.default-versions.mk: bump LLVM_DEFAULT to 15

    - graphics/mesa* switched to LLVM version 15 some time ago
    - desktop systems suffer from requiring many different LLVM versions
    - having the default at something recent combined with the version
      matching of llvm.mk (prefering $LLVM_DEFAULT) this should lessen
      the number of LLVM installations on normal systems again alot.

    - while here, remove outdated comment. x11@ switched to setting the
      LLVM version explicitely as the default was way out of date.

    PR:             263456
    Exp-run by:     antoine

 Mk/bsd.default-versions.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Comment 30 Tobias C. Berner freebsd_committer freebsd_triage 2023-01-03 09:24:33 UTC 
Committed. Thanks for the exp-run.