Bug 263587 - www/firefox 100.0,2 fails to build with configure error using poudriere on stable-13 amd64
Summary: www/firefox 100.0,2 fails to build with configure error using poudriere on st...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-26 15:29 UTC by Robert Cina
Modified: 2022-04-26 18:55 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (gecko)


Attachments
www/firefox poudriere build log of configure error (88.62 KB, text/plain)
2022-04-26 15:29 UTC, Robert Cina
no flags Details
moz.build from 14.0-CURRENT, unclean environment (2.40 KB, text/plain)
2022-04-26 18:01 UTC, Rainer Hurling
no flags Details
moz.build (2.40 KB, text/plain)
2022-04-26 18:06 UTC, iron.udjin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Cina 2022-04-26 15:29:02 UTC
Created attachment 233509 [details]
www/firefox poudriere build log of configure error

The port www/firefox fails to build with a configure error using poudriere on my Stable-13 amd64 system.

This is the error that is reported in the build log:

mozbuild.frontend.reader.BuildReaderError: 
==============================
FATAL ERROR PROCESSING MOZBUILD FILE
==============================

The error occurred while processing the following file:

    /wrkdirs/usr/ports/www/firefox/work/firefox-100.0/media/libcubeb/src/moz.build

The underlying problem is a Python syntax error on line 62:

    if CONFIG['MOZ_AUDIOUNIT_RUST']:


Fix the syntax error and try again.


The following is the output where the configure error occurs during the build:

checking for --ignore-unresolved-symbol option to ld... no
checking whether the linker supports Identical Code Folding... no
checking whether removing dead symbols breaks debugging... Traceback (most recent call last):
  File "/usr/local/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/wrkdirs/usr/ports/www/firefox/work/firefox-100.0/python/mozbuild/mozbuild/configure/check_debug_ranges.py", line 70, in <module>
    print(main(*sys.argv[1:]))
  File "/wrkdirs/usr/ports/www/firefox/work/firefox-100.0/python/mozbuild/mozbuild/configure/check_debug_ranges.py", line 49, in main
    p = subprocess.Popen(
  File "/usr/local/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/local/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'objdump'
Comment 1 Rainer Hurling freebsd_committer freebsd_triage 2022-04-26 16:28:37 UTC
The same error seems to happen on 14.0-CURRENT, also in non-clean environments.
Comment 2 iron.udjin 2022-04-26 17:03:22 UTC
The same error on 13.1-STABLE stable/13-n250549-d47ac32b4a4f
Comment 3 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2022-04-26 17:52:19 UTC
That's interesting as firefox builds just fine on 13.0-RELEASE (poudriere) - this comment is being written in a poudriere-built firefox-100.

Could someone get that media/libcubeb/src/moz.build file from a failing workdir? The file I have is completely "normal" and doesn't give any indication on how it could fail.
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2022-04-26 18:01:30 UTC
Created attachment 233511 [details]
moz.build from 14.0-CURRENT, unclean environment

This is from a 14.0-CURRENT build in an unclean environment.
Comment 5 iron.udjin 2022-04-26 18:06:55 UTC
Created attachment 233512 [details]
moz.build
Comment 6 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2022-04-26 18:10:10 UTC
jkim@ identified SNDIO as the trigger, and I see how that happens. Stand by for test build.
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-04-26 18:52:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=48a481f83ecbb669a22c2c9f9dc3712bf5a7b71c

commit 48a481f83ecbb669a22c2c9f9dc3712bf5a7b71c
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2022-04-26 18:49:11 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2022-04-26 18:49:11 +0000

    www/firefox: fix build with sndio

    upstream sndio handling was fixed for non-OpenBSD systems:
    https://bugzilla.mozilla.org/show_bug.cgi?id=1351378
    so our own "fixing" actually broke build.

    PR:             263587
    Reported by:    Robert Cina, jkim@

 Mk/bsd.gecko.mk | 5 +++++
 1 file changed, 5 insertions(+)
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-04-26 18:53:32 UTC
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dc17c19f15dab57c22d2967a525573d4b8020930

commit dc17c19f15dab57c22d2967a525573d4b8020930
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2022-04-26 18:49:11 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2022-04-26 18:53:05 +0000

    www/firefox: fix build with sndio

    upstream sndio handling was fixed for non-OpenBSD systems:
    https://bugzilla.mozilla.org/show_bug.cgi?id=1351378
    so our own "fixing" actually broke build.

    PR:             263587
    Reported by:    Robert Cina, jkim@

    (cherry picked from commit 48a481f83ecbb669a22c2c9f9dc3712bf5a7b71c)

 Mk/bsd.gecko.mk | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Comment 9 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2022-04-26 18:55:29 UTC
that seems to fix the issue. I'll clean it up one -esr passes 100.