Bug 263634 - devel/gettext-tools: don't disable openmp
Summary: devel/gettext-tools: don't disable openmp
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-28 17:13 UTC by Piotr Kubaj
Modified: 2022-05-19 09:12 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (tijl)

Attachments
patch (826 bytes, patch)
2022-04-28 17:13 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2022-04-28 17:13:16 UTC 
Created attachment 233565 [details]
patch

OpenMP is gettext was disabled 15 years ago in https://cgit.freebsd.org/ports/commit/devel/gettext/Makefile?id=bfe8a9ab273f573d122fd3ae04fdd85d73d0b6e2

Building with OpenMP left for autodetection works on both powerpc (which doesn't have libomp) and on powerpc64 (which does have libomp), so I guess it's ok to remove disabling it.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2022-05-16 21:01:12 UTC 
Assigning to portmgr, as indicated by Makefile.
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2022-05-19 08:00:17 UTC 
This looks fine.
Please bump PORTREVISION of gettext-tools.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-05-19 09:12:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ebce5896d4015c4700d62f1d028499d70c30f2f7

commit ebce5896d4015c4700d62f1d028499d70c30f2f7
Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
AuthorDate: 2022-05-19 09:07:43 +0000
Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
CommitDate: 2022-05-19 09:07:43 +0000

    devel/gettext-tools: don't disable openmp

    OpenMP is gettext was disabled 15 years ago in bfe8a9ab273f573d122fd3ae04fdd85d73d0b6e2

    Building with OpenMP left for autodetection works on both powerpc (which
    doesn't have libomp) and on powerpc64 (which does have libomp), so it's ok to
    remove disabling it.

    PR:     263634
    Approved by:    antoine

 devel/gettext-tools/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)