Created attachment 233576 [details] databases/py-hiredis: Update to 2.0.0 This patch updates databases/py-hiredis to 2.0.0. I've adapted the fixes necessary for setup.py to use our shipped version of databases/hiredis in place of the internal vendored one (which is used by default), but I am honestly not entirely sure I've gotten it right and would appreciate some feedback on this. The port builds with databases/hiredis 1.0.2 that was submitted in bug 263647. I've managed to run the tests against the installed package, where it works fine, but for some reason was unable to get test.py to pass in the test stage against the local build, hence I've not been able to include a test target. :/ Since the port doesn't build with the current hiredis version in port I've been thinking of adding a version bound on databases/hiredis, but I'm not sure how to do that with LIB_DEPENDS. :/ Any feedback on this is greatly appreciated. I will probably try and test this with a synapse worker setup to get some more reliable/in-production testing done as well. Cheers, Sascha
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=eeaf03e841b61dbea0cbea92b7b6126824d25dd5 commit eeaf03e841b61dbea0cbea92b7b6126824d25dd5 Author: Jimmy Olgeni <olgeni@FreeBSD.org> AuthorDate: 2022-04-29 13:59:19 +0000 Commit: Jimmy Olgeni <olgeni@FreeBSD.org> CommitDate: 2022-04-29 19:35:59 +0000 databases/py-hiredis: update to version 2.0.0 PR: 263649 Reported by: Sascha Biberhofer databases/py-hiredis/Makefile | 2 +- databases/py-hiredis/distinfo | 5 +++-- databases/py-hiredis/files/patch-setup.py | 19 +++++++------------ 3 files changed, 11 insertions(+), 15 deletions(-)
The path to hiredis seems correct according to ldd :) I need to look into the test target..
^Triage: over to committer to see if the comment about "test case" is still valid.