Bug 263690 - devel/oniguruma: Tidy up port and switch to release archive
Summary: devel/oniguruma: Tidy up port and switch to release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-30 18:47 UTC by Daniel Engberg
Modified: 2022-04-30 19:15 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Patch for oniguruma (3.26 KB, patch)
2022-04-30 18:47 UTC, Daniel Engberg 		no flags Details | Diff
Patch for oniguruma v2 (3.26 KB, patch)
2022-04-30 18:49 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-04-30 18:47:55 UTC 
Created attachment 233614 [details]
Patch for oniguruma

Switch to using upstream release archive
Backport upstream commmit 1f322c45aa365d377e1d7db567bb7087c7c1b38c to fix build issue with examples
Switch to CMake which builds faster and tidies up ports Makefile, unfortunately test suite isn't connected to CMake yet
Remove non working STATISTICS toggle

References:
https://github.com/kkos/oniguruma/issues/254
https://github.com/kkos/oniguruma/issues/256

Compile tested on FreeBSD 13.1-STABLE #0 stable/13-n250098-4081882c415 (amd64) (make, make check-plist)
Poudriere testport OK 12.3-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-04-30 18:49:52 UTC 
Created attachment 233615 [details]
Patch for oniguruma v2

Fix typo
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-04-30 19:15:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9a245d16f59f11a4f4afdf754062af57a91e8702

commit 9a245d16f59f11a4f4afdf754062af57a91e8702
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-04-30 19:14:27 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-04-30 19:14:27 +0000

    devel/oniguruma: Switch to release archive, tidy up port, install cmake files

    PR:             263690

 devel/oniguruma/Makefile  | 39 ++++++++++++++++-----------------------
 devel/oniguruma/distinfo  |  8 +++++---
 devel/oniguruma/pkg-plist |  4 ++++
 3 files changed, 25 insertions(+), 26 deletions(-)
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2022-04-30 19:15:51 UTC 
Committed.

Thanks for the patch!