Bug 263729 - databases/redis: Enable TLS by default
Summary: databases/redis: Enable TLS by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jason Helfman
URL:
Keywords: feature
Depends on:
Blocks:
 
Reported: 2022-05-02 15:01 UTC by pete
Modified: 2022-05-19 00:30 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (yasu)

Attachments
example of enabling TLS to databases/redis Makefile (433 bytes, patch)
2022-05-02 15:01 UTC, pete 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pete 2022-05-02 15:01:14 UTC 
Created attachment 233672 [details]
example of enabling TLS to databases/redis Makefile

hello, as more environments support and enforce TLS by default for Redis it would be very helpful to have this build option enabled by default for our port.  i have tested locally, and by enabling the TLS option I am able to connect to AWS MemoryDB (which enforces TLS by default) using the redis-cli.  It does not seem to have an effect on scenarios where you do not want to use TLS either.
Comment 1 Michael Gmelin freebsd_committer freebsd_triage 2022-05-16 13:30:00 UTC 
(In reply to pete from comment #0)
+1
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-05-18 19:53:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=08d405638b51f728c8428263a8a2be0019365803

commit 08d405638b51f728c8428263a8a2be0019365803
Author:     Jason Helfman <jgh@FreeBSD.org>
AuthorDate: 2022-05-18 19:38:56 +0000
Commit:     Jason Helfman <jgh@FreeBSD.org>
CommitDate: 2022-05-18 19:52:01 +0000

    databases/redis: turn on TLS option by default

    PR:             263729
    Submitted by:   pete@nomadlogic.org
    Approved by:    maintainer-timeout (two weeks)

 databases/redis/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Comment 3 Jason Helfman freebsd_committer freebsd_triage 2022-05-18 19:53:51 UTC 
Updated. Thanks for the report!
-jgh