Bug 263837 - graphics/drm-510-kmod: fails to build in current after devclass removal
Summary: graphics/drm-510-kmod: fails to build in current after devclass removal
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-07 12:22 UTC by Trond Endrestøl
Modified: 2023-11-27 10:28 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)


Attachments
Patch for graphics/drm-510-kmod after devclass removal (1.38 KB, patch)
2022-05-07 12:22 UTC, Trond Endrestøl
no flags Details | Diff
Patch for graphics/drm-510-kmod after devclass removal, now conditional on __FreeBSD_version >= 1400058 (1.38 KB, patch)
2022-05-07 18:18 UTC, Trond Endrestøl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2022-05-07 12:22:40 UTC
Created attachment 233788 [details]
Patch for graphics/drm-510-kmod after devclass removal

I wish the ABI number got incremented for this change. Some users might be on 1400057 and have a source tree lacking the devclass removal. Anyone daring to run current are probably aware of things breaking from time to time.
Comment 1 Warner Losh freebsd_committer freebsd_triage 2022-05-07 15:35:33 UTC
2e32d4e41d205d6f14834f87306a77ff77b9c0bd bumps the version to 1400058 just a few hours after John's commits. Please use that for any conditional fixes.
Comment 2 Trond Endrestøl 2022-05-07 18:18:42 UTC
Created attachment 233796 [details]
Patch for graphics/drm-510-kmod after devclass removal, now conditional on __FreeBSD_version >= 1400058
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-05-08 10:10:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7b4d08cec112f8436cb160332d156ce5cf60b344

commit 7b4d08cec112f8436cb160332d156ce5cf60b344
Author:     Emmanuel Vadot <manu@FreeBSD.org>
AuthorDate: 2022-05-08 10:08:20 +0000
Commit:     Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2022-05-08 10:09:28 +0000

    graphics/drm-510-kmod: Fix build on recent CURRENT

    PR:             263837
    Sponsored by:   Beckhoff Automation GmbH & Co. KG

 graphics/drm-510-kmod/Makefile | 3 ++-
 graphics/drm-510-kmod/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)
Comment 4 Zsolt 2022-08-12 17:43:31 UTC
I am on Current. Wanted to upgrade today to drm-kmod-drm_v5.10.113_3 but it failed half way

--- drm_scdc_helper.o ---
cc  -O2 -pipe -fno-strict-aliasing '-DKBUILD_MODNAME="drm"' '-DLINUXKPI_PARAM_PREFIX=drm_' -DDRM_SYSCTL_PARAM_PREFIX=_dri -DLINUXKPI_VERSION=50000 -DCONFIG_DRM_AMDGPU_CIK -DCONFIG_DRM_AMDGPU_SI -DCONFIG_DRM_AMD_DC -DCONFIG_DRM_AMD_DC_SI -DCONFIG_DRM_I915_FORCE_PROBE='"*"' -DCONFIG_DRM_I915_CAPTURE_ERROR -DCONFIG_DRM_I915_USERFAULT_AUTOSUSPEND=250 -DCONFIG_DRM_I915_STOP_TIMEOUT=100 -DCONFIG_DRM_I915_PREEMPT_TIMEOUT=640 -DCONFIG_DRM_I915_HEARTBEAT_INTERVAL=2500 -DCONFIG_DRM_I915_TIMESLICE_DURATION=1 -DCONFIG_DRM_I915_MAX_REQUEST_BUSYWAIT=8000 -DCONFIG_DRM_I915_FENCE_TIMEOUT=10000 -DCONFIG_DRM_MIPI_DSI -DCONFIG_DRM_PANEL_ORIENTATION_QUIRKS -DCONFIG_DRM_FBDEV_EMULATION -DCONFIG_DRM_FBDEV_OVERALLOC=100 -DCONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG -DCONFIG_BACKLIGHT_CLASS_DEVICE -DCONFIG_DMI -DCONFIG_FB -DCONFIG_MTRR -DCONFIG_PCI -DCONFIG_PM -DCONFIG_SMP -DCONFIG_ACPI -DCONFIG_ACPI_SLEEP -DCONFIG_X86 -DCONFIG_X86_PAT -DCONFIG_64BIT -DCONFIG_AS_MOVNTDQA -DCONFIG_COMPAT -DCONFIG_X86_64 -DCONFIG_DRM_AMD_DC_DCN -DCONFIG_DRM_AMD_DC_DCN3_0  -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I/usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/linuxkpi/gplv2/include -I/usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/linuxkpi/bsd/include -I/usr/src/sys/compat/linuxkpi/common/include -I/usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/linuxkpi/dummy/include -I/usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/drivers/gpu/drm -I/usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/include -I/usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/include/drm -I/usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/include/uapi -I/usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/drivers/gpu -include /usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/obj/usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/drm/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include     -MD  -MF.depend.drm_scdc_helper.o -MTdrm_scdc_helper.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wno-pointer-sign -Wno-format -Wno-error=unused-but-set-variable -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/drivers/gpu/drm/drm_scdc_helper.c -o drm_scdc_helper.o
--- drm_prime.o ---
1 error generated.
*** [drm_prime.o] Error code 1

make[2]: stopped in /usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/drm
1 error

make[2]: stopped in /usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3/drm

make[1]: stopped in /usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_3
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/drm-510-kmod