Bug 263840 - net-p2p/lidarr: Update to 1.0.2.2592 and switch from mono to .net
Summary: net-p2p/lidarr: Update to 1.0.2.2592 and switch from mono to .net
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Felix Palmen
URL: https://github.com/Lidarr/Lidarr/rele...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-07 13:56 UTC by Michiel van Baak Jansen
Modified: 2022-08-12 13:10 UTC (History)
1 user (show)

See Also:

Attachments
0001-net-p2p-lidarr-Update-to-1.0.0.2570.patch (31.84 KB, patch)
2022-05-07 13:56 UTC, Michiel van Baak Jansen 		michiel: maintainer-approval+
Details | Diff
0001-net-p2p-lidarr-Update-to-1.0.2.2592.patch (31.87 KB, patch)
2022-06-06 08:53 UTC, Michiel van Baak Jansen 		michiel: maintainer-approval+
Details | Diff
0001-net-p2p-lidarr-Update-to-1.0.2.2592.patch (32.04 KB, patch)
2022-08-12 12:20 UTC, Michiel van Baak Jansen 		michiel: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michiel van Baak Jansen 2022-05-07 13:56:55 UTC 
Created attachment 233789 [details]
0001-net-p2p-lidarr-Update-to-1.0.0.2570.patch

portclippy agrees
poudriere ok
runs in production on my setup (13.0 amd64)

This update also switches the port from mono to .net all-included binary.
This same switch has been done with the net-p2p/radarr and net-p2p/prowlarr port before, and performance and stability is a lot better.
Comment 1 Michiel van Baak Jansen 2022-06-06 08:53:59 UTC 
Created attachment 234486 [details]
0001-net-p2p-lidarr-Update-to-1.0.2.2592.patch
Comment 2 Felix Palmen freebsd_committer freebsd_triage 2022-08-10 15:32:03 UTC 
Hi Michiel,

depending on openssl directly will create all sorts of problems (IIRC, for example, you can't build any ports with USES=ssl when it is installed and *not* configured as the default ssl version).

Would USES= ssl:run work instead? It wouldn't install anything in the default configuration (OpenSSL from base).
Comment 3 Michiel van Baak Jansen 2022-08-12 12:20:09 UTC 
(In reply to Felix Palmen from comment #2)
Tested without any *ssl ports/packages installed: works
Tested with the openssl package installed: works (this is how it was, so no suprise here)
Tested with the libressl package installed: works

So I switched the port to the USES=ssl:run as you suggested. Good catch!

I will send in patches for the other *arr ports.
Comment 4 Michiel van Baak Jansen 2022-08-12 12:20:41 UTC 
Created attachment 235860 [details]
0001-net-p2p-lidarr-Update-to-1.0.2.2592.patch
Comment 5 Michiel van Baak Jansen 2022-08-12 12:21:41 UTC 
Comment on attachment 235860 [details]
0001-net-p2p-lidarr-Update-to-1.0.2.2592.patch

poudriere ok
Tested in my production setup (13.1 amd64 clean jail without the openssl package installed to make sure the new USES=ssl:run works as expected)
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-08-12 13:05:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5454a6062bb001c41954bb407b3203ca34e41003

commit 5454a6062bb001c41954bb407b3203ca34e41003
Author:     Michiel van Baak Jansen <michiel@vanbaak.eu>
AuthorDate: 2022-05-07 10:41:36 +0000
Commit:     Felix Palmen <zirias@FreeBSD.org>
CommitDate: 2022-08-12 13:03:52 +0000

    net-p2p/lidarr: Update to 1.0.2.2592

    This version released a FreeBSD .NET (core) binary.
    Setup is the same as net-p2p/radarr and net-p2p/prowlarr

    While at it, switch to USES=ssl:run so openssl package is not a hard
    dependency. Tested with base ssl, openssl package and libressl package
    installed.

    ARCH Restriction to amd64 discussed on IRC with maintainer. lidarr
    upstream will stop supporting mono in the next release. The .NET SDK
    used to build this version only exists for amd64 so far (and isn't
    public either). There's nothing that can be done about that as long as
    Microsoft doesn't officially support FreeBSD for .NET.

    PR:                     263840
    Approved by:            tcberner (mentor)
    Differential Revision:  https://reviews.freebsd.org/D36172

 net-p2p/lidarr/Makefile             |  37 ++---
 net-p2p/lidarr/distinfo             |   6 +-
 net-p2p/lidarr/files/lidarr.in      |  69 ++++----
 net-p2p/lidarr/files/pkg-message.in |   7 +
 net-p2p/lidarr/pkg-plist            | 313 ++++++++++++++++++++++++++++--------
 5 files changed, 316 insertions(+), 116 deletions(-)
Comment 7 Felix Palmen freebsd_committer freebsd_triage 2022-08-12 13:10:27 UTC 
Committed, thanks!