Bug 263863 - graphics/darktable: Fix non functional HEIF option
Summary: graphics/darktable: Fix non functional HEIF option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-05-08 15:28 UTC by Philipp Ost
Modified: 2022-07-18 21:26 UTC (History)
2 users (show)

See Also:
dumbbell: maintainer-feedback+

Attachments
graphics/darktable: make HEIF an option (1.05 KB, patch)
2022-05-08 15:28 UTC, Philipp Ost 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2022-05-08 15:28:04 UTC 
Created attachment 233809 [details]
graphics/darktable: make HEIF an option

In commit fb1e02a81d205f693a9ff82bf65e889073d6ba7a darktable gained a HEIF option, but it is non-operational. This patch adds the missing bits.

poudriere testport is happy (13.0-p11 amd64).
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2022-05-09 16:55:41 UTC 
Removing koobs@'s "maintainer-feedback? mandree@" because I am not the maintainer, but dumbbell@ is, who has approved. 

But thanks for the Cc: of a patch I authored, not sure why/how it slipped through the cracks. Sorry for the mess.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-07-18 21:26:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d47785c3f7b42a6b43d73976049229d27d30330e

commit d47785c3f7b42a6b43d73976049229d27d30330e
Author:     Philipp Ost <bsd@philippost.de>
AuthorDate: 2022-07-02 22:15:28 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2022-07-18 21:25:20 +0000

    graphics/darktable: Fix non-functional HEIF option.

    [omitting the HEIF_DESC which is now centrally managed]

    PR:             263863

 graphics/darktable/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2022-07-18 21:26:43 UTC 
This had been approved by dumbbell@ 10+ weeks ago, so let's get this committed.