Bug 263869 - x11/xscreensaver: Fails to build, missing XFT dependency: error: use of undeclared identifier 'FcChar32'
Summary: x11/xscreensaver: Fails to build, missing XFT dependency: error: use of undec...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Piotr Kubaj
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2022-05-08 19:12 UTC by Thomas Zander
Modified: 2022-05-16 22:03 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Zander freebsd_committer freebsd_triage 2022-05-08 19:12:53 UTC 
Building xscreensaver without XFT fails:

...
dialog.c:695:11: warning: implicit declaration of function 'XftCharExists' [-Wimplicit-function-declaration]
      if (XftCharExists (ws->dpy, ws->label_font, (FcChar32) *uc))
          ^
dialog.c:695:52: error: use of undeclared identifier 'FcChar32'
      if (XftCharExists (ws->dpy, ws->label_font, (FcChar32) *uc))
                                                   ^
1 warning and 1 error generated.


It seems like XFT is required. From the configure stage output:

...
    Warning: The XFreeType library was not found.  It is required.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-05-16 22:02:16 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=16efa5a804e5bdc8e319809155f4122960a5f3ee

commit 16efa5a804e5bdc8e319809155f4122960a5f3ee
Author:     Adriaan de Groot <adridg@FreeBSD.org>
AuthorDate: 2022-05-16 21:55:28 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2022-05-16 22:01:50 +0000

    x11/xscreensaver: remove XFT option

    Xft isn't optional: it is mandatory, and xscreensaver configure
    complains if it isn't there (but completes with a successful
    exit code, which is a bit strange). Without XFT, the build
    eventually fails like so:

    dialog.c:695:52: error: use of undeclared identifier 'FcChar32'
          if (XftCharExists (ws->dpy, ws->label_font, (FcChar32) *uc))

    PR:             263869
    Reported by:    riggs
    Approved by:    build-fix blanket

 x11/xscreensaver/Makefile | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)