Created attachment 233893 [details] multimedia/nymphcast: fix build on armv7 The build failed due to an unsupported compiler option -Wa,-mimplicit-it=thumb. This option is not needed when building with clang, doubly so when building in ARM mode, which we do. Please also consider changing the Makefile such that CC and CXX are respected. This can be done e.g. by MAKE_ARGS= GCC=${CC} GPP=${CXX} in the port Makefile. Tested with Poudriere on armv7 FreeBSD 13.
Looks good to me, but .. wouldn't it *overall* be better to use `lang/angelscript` rather than a bundled copy? Is that something you would like to chase in NymphCast? (If not and you just want stuff to build on ARM, that's fine too and I'll land this instead)
(In reply to Adriaan de Groot from comment #1) Hi, my mission is to make more ports build on armv7. I don't care about this port specifically, it just looked like an issue that is easy to fix. I agree that unbundling the dependency would be in general a better solution. Feel free to do that instead of committing my patch. If you post it here, I can check if it makes the build work on armv7.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=78989b4e694c2a8264975fb6d64e3bf1c13762c2 commit 78989b4e694c2a8264975fb6d64e3bf1c13762c2 Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-05-16 15:00:32 +0000 Commit: Adriaan de Groot <adridg@FreeBSD.org> CommitDate: 2022-05-16 18:57:54 +0000 multimedia/nymphcast: fix build on ARMv7 nymphcast has a bundled copy of angelscript (TODO: use the one from ports instead) that doesn't build nicely on ARM because it passes in invalid compiler flags. PR: 263953 Reported by: Robert Clausecker multimedia/nymphcast/Makefile | 1 + multimedia/nymphcast/files/patch-armv7 (new) | 58 ++++++++++++++++++++++++++++ 2 files changed, 59 insertions(+)
Thanks! Please don't forget to MFH.
Hi Adrian, Checking on this issue again, you have applied the patch I sent wrongly. The patch is not meant to be placed into the files directory, but should rather be applied to the ports tree as a whole (using git-am). Please remove the wrong patch and reapply it correctly.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d63834673696356f0c15a9f00d7cda102bdc4316 commit d63834673696356f0c15a9f00d7cda102bdc4316 Author: Adriaan de Groot <adridg@FreeBSD.org> AuthorDate: 2022-06-30 21:45:05 +0000 Commit: Adriaan de Groot <adridg@FreeBSD.org> CommitDate: 2022-06-30 22:21:12 +0000 multimedia/nymphcast: fix botched previous commit I have no idea what I was thinking in 78989b4e694c2a8264975fb6d64e3bf1c13762c2, which added a patch-file, instead of patching with that patch file to create patch files. PR: 263953 Reported by: Robert Clausecker ...angelscript_projects_cmake_CMakeLists.txt (new) | 10 ++++ ...script_angelscript_projects_gnuc_Makefile (new) | 17 +++++++ multimedia/nymphcast/files/patch-armv7 (gone) | 58 ---------------------- 3 files changed, 27 insertions(+), 58 deletions(-)
Thanks for the commit!