Bug 264043 - devel/py-click: Missing dependency (latest/quarterly): click 8.0.3 requires importlib-metadata, which is not installed.
Summary: devel/py-click: Missing dependency (latest/quarterly): click 8.0.3 requires i...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-17 12:09 UTC by Michael Osipov
Modified: 2022-07-28 15:46 UTC (History)
3 users (show)

See Also:
pi: maintainer-feedback-
pi: merge-quarterly+

Attachments
Git-formatted patch (655 bytes, patch)
2022-07-28 07:56 UTC, Michael Osipov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov 2022-05-17 12:09:56 UTC 
pip tells me:
root@deblndw011x1j:/usr/ports/www/py-flask
# pip check
flask 2.1.0 requires importlib-metadata, which is not installed.
click 8.0.3 requires importlib-metadata, which is not installed.

because both https://cgit.freebsd.org/ports/tree/devel/py-click/Makefile#n36 and https://cgit.freebsd.org/ports/tree/devel/py-click/Makefile?h=2022Q2 miss dependency on devel/py-importlib-metadata.

Apply the same hunk as in www/py-flask: https://cgit.freebsd.org/ports/tree/www/py-flask/Makefile#n32 to BOTH branches.
Comment 1 Michael Osipov 2022-05-17 12:12:12 UTC 
Ref from Python 3.10: https://docs.python.org/3/library/importlib.metadata.html
Comment 2 Michael Osipov 2022-07-28 07:56:24 UTC 
Created attachment 235521 [details]
Git-formatted patch

Here is a patch against main. Please apply against main and 2022Q3.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-07-28 09:19:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=631cbf11b6594c79aaa85f97d4cdc27f4d65a66b

commit 631cbf11b6594c79aaa85f97d4cdc27f4d65a66b
Author:     Michael Osipov <michael.osipov@siemens.com>
AuthorDate: 2022-07-28 09:16:44 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2022-07-28 09:16:44 +0000

    devel/py-click: add missing dependency for python < 3.10

    - see https://docs.python.org/3/library/importlib.metadata.html

    PR:             264043
    Approved:       robak (maintainer timeout)

 devel/py-click/Makefile | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-07-28 09:28:24 UTC 
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=399486c657b0053ddc7c41b985aaecf6d134ecee

commit 399486c657b0053ddc7c41b985aaecf6d134ecee
Author:     Michael Osipov <michael.osipov@siemens.com>
AuthorDate: 2022-07-28 09:16:44 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2022-07-28 09:27:23 +0000

    devel/py-click: add missing dependency for python < 3.10

    - see https://docs.python.org/3/library/importlib.metadata.html

    PR:             264043
    Approved:       robak (maintainer timeout)
    (cherry picked from commit 631cbf11b6594c79aaa85f97d4cdc27f4d65a66b)

 devel/py-click/Makefile | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 5 Michael Osipov 2022-07-28 10:05:36 UTC 
Fantastic, thank you.