Bug 264137 - games/libretro-desmume2015: JIT incorrectly disabled
Summary: games/libretro-desmume2015: JIT incorrectly disabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-21 21:28 UTC by Henry Hu
Modified: 2022-10-22 17:57 UTC (History)
2 users (show)

See Also:
dmenelkir: maintainer-feedback+

Attachments
v1 (653 bytes, patch)
2022-05-27 22:41 UTC, Daniel Menelkir 		dmenelkir: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2022-05-21 21:28:15 UTC 
The current Makefile says

.if ${ARCH} != aarch64 || ${ARCH} != amd64 || !${ARCH:Marmv*} || ${ARCH} != i386
MAKE_ENV+=	DESMUME_JIT=0
.endif


As you can see, since ARCH can only take one value, this always disables JIT.
I think the conditions should be combined with &&, not ||.
Comment 1 Daniel Menelkir 2022-05-27 22:41:56 UTC 
Created attachment 234273 [details]
v1

I've made the changes and bumped the PORTREVISION.
Tested on amd64.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-22 17:57:26 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=062f201c5e352d80be1e066f27c28e5d290f8b11

commit 062f201c5e352d80be1e066f27c28e5d290f8b11
Author:     Henry Hu <henry.hu.sh@gmail.com>
AuthorDate: 2022-10-22 17:55:39 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-10-22 17:56:28 +0000

    games/libretro-desmume2015: Fix JIT incorrectly disabled

    PR:             264137

 games/libretro-desmume2015/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)