Created attachment 234126 [details] dgedit.patch QA: * portlint: OK (looks fine.) * testport: OK (poudriere: 13.0, amd64 tested)
Hi Goran, Thanks for your patch, I've uploaded a revised version of your patch that "works for me" as far as Poudriere goes at least. If you could verify functionality it would be great. PORTVERSION --> DISTVERSION (see Porters Handbook - "Table 2. Package Naming Examples", rule of thumb is unless it breaks in weird ways always use DISTVERSION) A few comments in general BUILD_DEPENDS - Why is this listed? It's not mentioned in the source code at all LIB_DEPENDS - How did you come up with this list? In most cases you can use "ldd <path to so file>" to determine dependencies. ldd will show all linked libraries however no all libs are needed to be defined such as ones shipped in base. Poudriere will also complain about missing ones however not ones that aren't used. USE_XORG - ^ USE_QT - qmake uses .pro files as "Makefile", this project doesn't package such files. See https://doc.qt.io/qt-5/qmake-tutorial.html Easy to miss but we have a bunch of "helpers" that should be used if possible, in this case localbase (https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-localbase) Unfortunately not all are documentated but any listed here are available for use, https://cgit.freebsd.org/ports/tree/Mk/Uses/ Best regards, Daniel
Created attachment 234204 [details] Patch for dgedit v2 Also import https://salsa.debian.org/multimedia-team/dgedit/-/raw/cbed0f63c43aa06b8c9dc2b09d41dcbb71c931d6/debian/patches/0001-Fix-rcc-invocation.patch
Forgot to mention, "# Created by..." is deprecated treewide If you're updating a port or adding a new one it can be worth looking if other distributions to see if they carry patches that would also be useful in our case. repology.org can be very useful in that regard, in general I'd recommend looking at Arch, Alpine, Fedora, Debian and OpenSUSE .
First of all, thank you for all the comments, I learned a lot. Second, sorry it took a while for my old PC to compile llvm in poudriere. Your patch looks great and only thing it's missing is SUBDIR += dgedit in audio/Makefile. Once again, thank you for wise words!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=86192094f541c44b3b84d5d1c0638a6c2fc3654a commit 86192094f541c44b3b84d5d1c0638a6c2fc3654a Author: Goran Mekić <meka@tilda.center> AuthorDate: 2022-06-12 21:17:28 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2022-06-12 21:18:54 +0000 audio/dgedit: New port: DrumGizmo drumkit editor PR: 264156 audio/Makefile | 1 + audio/dgedit/Makefile (new) | 26 ++++++++++++++++++++++++++ audio/dgedit/distinfo (new) | 3 +++ audio/dgedit/files/patch-src_Makefile.am (new) | 11 +++++++++++ audio/dgedit/pkg-descr (new) | 9 +++++++++ 5 files changed, 50 insertions(+)
Committed, thanks!