Bug 264223 - [update]: databases/tarantool up to 2.10.0
Summary: [update]: databases/tarantool up to 2.10.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-25 07:54 UTC by Balaev PA
Modified: 2022-06-09 11:15 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
patch (12.06 KB, patch)
2022-05-25 07:54 UTC, Balaev PA
no flags Details | Diff
patch v1 (10.88 KB, patch)
2022-05-25 08:38 UTC, Balaev PA
no flags Details | Diff
patch v2 (9.02 KB, patch)
2022-06-06 08:36 UTC, Balaev PA
no flags Details | Diff
patch v3 (9.04 KB, patch)
2022-06-06 10:34 UTC, Balaev PA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balaev PA 2022-05-25 07:54:27 UTC
Created attachment 234192 [details]
patch

Hello. This patch upgrades database/tarantool to the latest release.

Port switches from github to official tarball.
Downloading a ready-made tarball with all the necessary versions of submodules simplifies port maintenance.

Also this release needs latest version of msgpuck library, so bundled version is used.

Issues for included patches:

* patch-cmake-BuildLibUnwind.cmake => ttps://github.com/tarantool/tarantool/issues/4278
* patch-src-CMakeLists.txt => https://github.com/tarantool/tarantool/issues/7180
* patch-test-unit-CMakeLists.txt => https://github.com/tarantool/tarantool/issues/7182
* patch-third_party-luajit-cmake-SetVersion.cmake => check git binary existence if we are in git repo (issue not created yet).
* patch-src-lib-tzcode-CMakeLists.txt => removed custom target that required git.

Deleted patches: (not needed anymore)

* patch-cmake-BuildMisc.cmake
* patch-cmake-FindICONV.cmake
Comment 1 Balaev PA 2022-05-25 08:38:27 UTC
Created attachment 234199 [details]
patch v1

Added second version of patch.

* removed unneded changes in patch-third_party-luajit-cmake-SetVersion.cmake
Comment 2 Balaev PA 2022-05-25 13:04:43 UTC
I am one of the developers of the tarantool project, we want to maintain this port so that the community receives updates in a timely manner.
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-06-03 10:46:09 UTC
(In reply to Balaev PA from comment #0)

> Also this release needs latest version of msgpuck library, so bundled version is used.

It is discourage to use bundled library. I could update devel/msgpuck to 0c6680a as well. We just need to check the other consumers:
- databases/tarantool-c
- www/nginx
- www/nginx-devel

BTW, does databases/tarantool-c need update?

(In reply to Balaev PA from comment #2)

> I am one of the developers of the tarantool project, we want to maintain this port so that the community receives updates in a timely manner.

I could pass databases/tarantool* and devel/msgpuck to you (or other member of upstream).
Comment 4 Balaev PA 2022-06-03 11:46:45 UTC
(In reply to Po-Chuan Hsieh from comment #3)

* databases/tarantool-c does not need to be updated since there were no new releases

* please set maintainer on database/tarantool* and devel/msgpuck to <balaev@tarantool.org>

I will test tarantool-c and ngx_http_tarantool(nginx/nginx-devel) with msgpuck@0c6680a and if it OK I will send a bug with updated msgpuck port and update this patch respectively.

Am I understanding the direction correctly?
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-06-03 12:54:42 UTC
(In reply to Balaev PA from comment #4)

Yes, you're right. I'll update both ports when you have the new patch. Thanks!
Comment 6 Balaev PA 2022-06-06 08:36:27 UTC
Created attachment 234485 [details]
patch v2

The patch (patch v2) has been reworked taking into account the updating of the msgpuck version (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264494)
Comment 7 Balaev PA 2022-06-06 10:34:29 UTC
Created attachment 234488 [details]
patch v3

Added version 3.
Patch was rebased with main branch.
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-06-09 11:06:05 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=345ae501c46756d919d0eac48be1df220e2a8953

commit 345ae501c46756d919d0eac48be1df220e2a8953
Author:     Pavel Balaev <balaev@tarantool.org>
AuthorDate: 2022-06-09 11:00:42 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2022-06-09 11:00:42 +0000

    databases/tarantool: Update to 2.10.0

    - Update MASTER_SITES: use upstream release tarball
      - Pass maintainership to upstream developer

    Changes:        https://github.com/tarantool/tarantool/releases
                    https://www.tarantool.io/en/doc/latest/release/notes/
    PR:             264223

 databases/tarantool/Makefile                       | 14 ++---
 databases/tarantool/distinfo                       | 18 ++-----
 .../files/patch-cmake-BuildLibUnwind.cmake (new)   | 29 +++++++++++
 .../files/patch-cmake-BuildMisc.cmake (gone)       | 17 ------
 .../files/patch-cmake-FindICONV.cmake (gone)       | 11 ----
 .../patch-src-lib-tzcode-CMakeLists.txt (new)      | 60 ++++++++++++++++++++++
 .../files/patch-test-unit-CMakeLists.txt (new)     | 14 +++++
 7 files changed, 109 insertions(+), 54 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-06-09 11:06:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1b0277b62185d8fc37b7a049393b03309585e78b

commit 1b0277b62185d8fc37b7a049393b03309585e78b
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2022-06-09 10:57:46 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2022-06-09 10:57:46 +0000

    databases/tarantool-c: Pass maintainership to upstream developer

    PR:             264223

 databases/tarantool-c/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 10 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-06-09 11:15:35 UTC
Committed. Thanks!