Bug 264255 - Mk/bsd.default-versions.mk: update Perl to 5.36
Summary: Mk/bsd.default-versions.mk: update Perl to 5.36
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Xin LI
URL:
Keywords:
Depends on: 273090 273093
Blocks:
  Show dependency treegraph
 
Reported: 2022-05-26 14:56 UTC by Mathieu Arnold
Modified: 2023-10-18 03:40 UTC (History)
6 users (show)

See Also:
antoine: exp-run+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2022-05-26 14:56:39 UTC
I'd like to change the default Perl version to 5.36, with a patch like this:

diff --git a/Mk/bsd.default-versions.mk b/Mk/bsd.default-versions.mk
index 5e4018a617dd..fd742caaab67 100644
--- a/Mk/bsd.default-versions.mk
+++ b/Mk/bsd.default-versions.mk
@@ -93,7 +93,7 @@ NINJA_DEFAULT?=               ninja
 # Possible values: 5.32, 5.34, 5.36, devel
 .  if !exists(${LOCALBASE}/bin/perl) || (!defined(_PORTS_ENV_CHECK) && \
     defined(PACKAGE_BUILDING))
-PERL5_DEFAULT?=                5.32
+PERL5_DEFAULT?=                5.36
 .  elif !defined(PERL5_DEFAULT)
 # There's no need to replace development versions, like "5.23" with "devel"
 # because 1) nobody is supposed to use it outside of poudriere, and 2) it must
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2022-05-29 18:45:51 UTC
Some new failure logs:

http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/p5-Regexp-Compare-0.33.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/claws-mail-perl-3.19.0.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/cyrus-imapd23-2.3.20_2.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/cyrus-imapd24-2.4.22.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/cyrus-imapd25-2.5.17_1.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/cyrus-imapd30-3.0.17_1.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/cyrus-imapd32-3.2.9_1.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/cyrus-imapd34-http-3.4.3_3.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/cyrus-imapd34-3.4.3_3.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/p5-Sendmail-Milter-0.18_2.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/p5-Math-Interpolate-1.06_1.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/polymake-4.6_3.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/opendchub-0.8.3.log
http://gohan04.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_18h59m34s/logs/errors/p5-Net-Gnats-0.22.log
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2022-06-01 13:18:51 UTC
I fixed the p5-* failures, I also upgrade Perl 5.36 to the release (from a release candidate) can you re-run ?
Comment 4 Mathieu Arnold freebsd_committer freebsd_triage 2022-06-06 09:58:25 UTC
Cyrus's problem is tracked in https://github.com/cyrusimap/cyrus-imapd/issues/4123
Comment 5 Frank Reppin 2022-09-10 22:55:08 UTC
Don't want to sound impatient - but will there be any progress here?
The cyrus people dealt with this issue (fixed it) for at least their master and 3.6 and 3.4 branch.
Thanks for your hard work!
Comment 6 Xin LI freebsd_committer freebsd_triage 2023-07-31 18:56:21 UTC
Can we do another exp-run and check if we can update the default Perl version to 5.36?
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-08-13 05:11:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=78ca3ba628f11ab02a16ce36df5158422ec2f91e

commit 78ca3ba628f11ab02a16ce36df5158422ec2f91e
Author:     Xin LI <delphij@FreeBSD.org>
AuthorDate: 2023-08-13 05:00:40 +0000
Commit:     Xin LI <delphij@FreeBSD.org>
CommitDate: 2023-08-13 05:01:38 +0000

    net-p2p/opendchub: Fix build with more recent Perl versions.

    PR:             ports/264255

 net-p2p/opendchub/Makefile                         |  1 +
 .../files/patch-src_xs__functions.c (new)          | 26 ++++++++++++++++++++++
 2 files changed, 27 insertions(+)
Comment 9 Xin LI freebsd_committer freebsd_triage 2023-08-22 05:53:50 UTC
I believe no more blocking issues is present, can we proceed with the version bump?
Comment 10 Brad Davis freebsd_committer freebsd_triage 2023-10-05 09:46:06 UTC
@antoine Can you rerun the exp-run?
Comment 11 Antoine Brodin freebsd_committer freebsd_triage 2023-10-17 11:26:29 UTC
Exp-run looks fine
Comment 12 commit-hook freebsd_committer freebsd_triage 2023-10-18 03:40:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=039a6a2aed7b227b06e07147e5246d04f0a004fb

commit 039a6a2aed7b227b06e07147e5246d04f0a004fb
Author:     Xin LI <delphij@FreeBSD.org>
AuthorDate: 2023-10-18 03:38:40 +0000
Commit:     Xin LI <delphij@FreeBSD.org>
CommitDate: 2023-10-18 03:38:40 +0000

    Mk/bsd.default-versions.mk: Update the default Perl version to 5.36.

    PR:             ports/264255
    Exp-run by:     antoine

 Mk/bsd.default-versions.mk | 2 +-
 UPDATING                   | 9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)