Bug 264285 - net-mgmt/cacti: fix pkg-plist
Summary: net-mgmt/cacti: fix pkg-plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-27 13:30 UTC by David Siebörger
Modified: 2022-05-27 18:32 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (m.muenz)

Attachments
patch to correct pkg-plist (635 bytes, patch)
2022-05-27 13:30 UTC, David Siebörger 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Siebörger 2022-05-27 13:30:44 UTC 
Created attachment 234263 [details]
patch to correct pkg-plist

The entries below from pkg-plist cause the package stage to fail if CACTIUSER is set to anything other than "cacti":

%%CACTIDIR%%/docs/images/%%CACTIUSER%%-https.PNG
%%CACTIDIR%%/docs/images/%%CACTIUSER%%-log.png

The patch attached corrects that.

Here's what happens when CACTIUSER is set to "www":

===>  Building package for cacti-1.2.20
pkg-static: Unable to access file /wrkdirs/usr/ports/net-mgmt/cacti/work/stage/usr/local/share/cacti/docs/images/www-https.PNG:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/net-mgmt/cacti/work/stage/usr/local/share/cacti/docs/images/www-log.png:No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/net-mgmt/cacti
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-05-27 18:29:16 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=35303e5e3b493a841637bfa59ed61dbecdb7f52a

commit 35303e5e3b493a841637bfa59ed61dbecdb7f52a
Author:     David Siebörger <drs-freebsd@sieborger.nom.za>
AuthorDate: 2022-05-27 16:59:11 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-05-27 18:28:55 +0000

    net-mgmt/cacti: fix plist if CACTIUSER != cacti

    PR:             264285
    Reported by:    David Siebörger <drs-freebsd@sieborger.nom.za>
    Tested by:      meta
    Approved by:    blanket (plist fix)

 net-mgmt/cacti/pkg-plist | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2022-05-27 18:32:39 UTC 
Committed, thanks for the catch!