Bug 264327 - audio/pasystray: System tray icon to control PulseAudio
Summary: audio/pasystray: System tray icon to control PulseAudio
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2022-05-29 08:36 UTC by spamou
Modified: 2024-03-21 04:28 UTC (History)
2 users (show)

See Also:
julien+freebsdports: maintainer-feedback+

Attachments
Patch file for the audio/pasystray port (2.85 KB, patch)
2022-05-29 08:36 UTC, spamou 		no flags Details | Diff
patch after first review (2.77 KB, patch)
2022-05-30 01:44 UTC, spamou 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description spamou 2022-05-29 08:36:10 UTC 
Created attachment 234306 [details]
Patch file for the audio/pasystray port

pasystray is a tray icon allowing to control PulseAudio from your tray bar.  

- make stage ok
- make stage-qa ok
- make install ok
- make desinstall ok
- make package (as user) ok

portlint, portclippy and portfmt ok
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-05-29 23:08:54 UTC 
Congratulations on your first FreeBSD Port!

Minor review items:

- COMMENT: Strip “Pasystray is a”

- pkg-descr: Strip “This is a port of pasystray which is a”

- Remove GH_PROJECT and GH_TAGNAME, they already default to PORTNAME and PORTVERSION respectively

Keep up the great work.
Comment 2 spamou 2022-05-30 01:44:53 UTC 
Created attachment 234320 [details]
patch after first review

taking comment #1 into account
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-03-21 04:24:29 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d340d8ff321ab0f121147fb5e08c2b98c04c3f8d

commit d340d8ff321ab0f121147fb5e08c2b98c04c3f8d
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2024-03-21 04:23:46 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2024-03-21 04:23:46 +0000

    audio/pasystray: new port had been added (+)

    PulseAudio system tray, replacement for deprecated padevchooser.
    Add several options to disable unneeded features; unfortunately,
    AppIndicator support currently implies GTK v3 (the default one).

    PR:     264327

 audio/Makefile                  |  1 +
 audio/pasystray/Makefile (new)  | 42 +++++++++++++++++++++++++++++++++++++++++
 audio/pasystray/distinfo (new)  |  3 +++
 audio/pasystray/pkg-descr (new) |  5 +++++
 audio/pasystray/pkg-plist (new) |  6 ++++++
 5 files changed, 57 insertions(+)
Comment 4 Alexey Dokuchaev freebsd_committer freebsd_triage 2024-03-21 04:28:58 UTC 
Committed with various modifications and improvements, sorry it took us so long.