Created attachment 234317 [details] D35346.diff - Add support for selecting Go port version in USES=go; - Set default Go version (GO_DEFAULT) in Mk/bsd.default-versions.mk - Convert lang/go-devel port to the master and lang/go{117,118} ports to simple slave ports; - Convert lang/go to a meta-port that provides go and gofmt symlinks to the current default version. Other changes are port build fixes, they - Add 1.17 to USES=go for ports that still need go117 and remove GO_PORT; - Add missing ${SETENV} ${MAKE_ENV} to repair BINARY_ALIAS; - Remove explicit dependencies on lang/go. Expected build failures: - mail/aerc: dependency net/dante fails to configure - multimedia/navidrome: npm build error - sysutils/openshift-install: fails at fetch stage
lang/go118 has to be hooked to lang/Makefile
Created attachment 234379 [details] D35346-fixed.diff Fixed, thanks.
Exp-run looks fine
Thanks for the exp-run, Antoine.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b16eb860cc492d498eea6df7f481c93bbc851167 commit b16eb860cc492d498eea6df7f481c93bbc851167 Author: Dmitri Goutnik <dmgk@FreeBSD.org> AuthorDate: 2022-05-29 21:54:42 +0000 Commit: Dmitri Goutnik <dmgk@FreeBSD.org> CommitDate: 2022-06-06 18:19:10 +0000 */*: Repair after switching to versioned Go ports - Add 1.17 to USES=go for ports that still need go117, remove GO_PORT; - Add missing ${SETENV} ${MAKE_ENV} to repair BINARY_ALIAS; - Remove explicit dependencies on lang/go. PR: 264336 Reviewed by: ygy jwb yuri mikael drtr0jan@yandex.ru decke mat Differential Revision: https://reviews.freebsd.org/D35346 biology/ncbi-entrez-direct/Makefile | 2 +- devel/gocheese/Makefile | 2 +- devel/please/Makefile | 3 +-- net-im/gotosocial/Makefile | 2 +- net-im/nextcloud-spreed-signaling/Makefile | 6 ++---- net-mgmt/chronograf/Makefile | 2 +- net/ooni-probe-cli/Makefile | 2 +- security/crowdsec-firewall-bouncer/Makefile | 5 ++--- security/crowdsec/Makefile | 3 +-- sysutils/chezmoi/Makefile | 2 +- sysutils/containerd/Makefile | 5 ++--- sysutils/datadog-agent/Makefile | 10 +++++----- sysutils/ipfs-go/Makefile | 3 +-- sysutils/ipget/Makefile | 2 +- sysutils/minikube/Makefile | 2 +- www/adguardhome/Makefile | 3 +-- 16 files changed, 23 insertions(+), 31 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3012ca2179ceb0e389fbeb30a66f9fe60a3cf5a1 commit 3012ca2179ceb0e389fbeb30a66f9fe60a3cf5a1 Author: Dmitri Goutnik <dmgk@FreeBSD.org> AuthorDate: 2022-05-29 21:45:43 +0000 Commit: Dmitri Goutnik <dmgk@FreeBSD.org> CommitDate: 2022-06-06 18:19:10 +0000 */*: Introduce versioned Go ports - Mk/Uses/go.mk: add support for selecting Go port version in USES=go; - Mk/bsd.default-versions.mk: add GO_DEFAULT; - convert lang/go-devel to the master and lang/go{117,118} to slave ports; - add lang/go meta-port that provides go and gofmt symlinks to the current default version. PR: 264336 Reviewed by: ygy jwb yuri mikael drtr0jan@yandex.ru decke mat Differential Revision: https://reviews.freebsd.org/D35346 Mk/Scripts/qa.sh | 3 + Mk/Uses/go.mk | 35 +++--- Mk/bsd.default-versions.mk | 2 + lang/Makefile | 1 + lang/go-devel/Makefile | 131 ++++++++++++++++++--- lang/go-devel/pkg-descr (new) | 4 + lang/go/Makefile | 126 ++------------------ lang/go/pkg-descr | 3 + lang/go117/Makefile | 28 ++--- lang/go117/distinfo | 6 +- lang/go118/Makefile (new) | 22 ++++ lang/{go => go118}/distinfo | 2 +- .../patch-src_cmd_go_internal_modload_vendor.go | 0 13 files changed, 199 insertions(+), 164 deletions(-)